tests: replace method withConsecutive #1025
Merged
Merged
Conversation
nabim777
force-pushed
the
tests/replaceMethods
branch
3 times, most recently
from
June 1, 2026 03:47
62e1414 to
5e9dbd7
Compare
nabim777
force-pushed
the
tests/replaceMethods
branch
2 times, most recently
from
June 5, 2026 03:50
c1aca76 to
7fc2c15
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
nabim777
force-pushed
the
tests/replaceMethods
branch
4 times, most recently
from
July 6, 2026 07:24
b770ed9 to
725de5e
Compare
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
nabim777
force-pushed
the
tests/replaceMethods
branch
from
July 6, 2026 09:05
a5605d4 to
dffb487
Compare
PHP Code CoverageCoverage after merging tests/replaceMethods into release/2.11 will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
nabim777
marked this pull request as ready for review
July 6, 2026 10:02
nabim777
requested review from
Kharonus,
ba1ash,
dominic-braeunlein,
individual-it,
julien-nc,
lindenthal,
psatyal,
saw-jan and
wielinde
as code owners
July 6, 2026 10:02
nabim777
changed the title
withConsecutive
saw-jan
approved these changes
Jul 6, 2026
saw-jan
added a commit
that referenced
this pull request
Jul 7, 2026
* test(api): setup api test coverage for oidc method (#1050) * test: separate test scenarios Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * test: disable ssl checks Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * test: add oidc setup API tests Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * test: cleanup team folders Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * test: fix scenarios Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * test: move teamfolder cleanup to relative context Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * test: teardown integration setup Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * chore: fix php code style Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * test: fix scenarios Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * test: fix scenario outline title Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * test: fix scenarios Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * test: use app password with OpenProject user Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * test: run teardown only if needed Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * test: fix scenario step indentation Co-authored-by: Nalem7 <61624650+nabim777@users.noreply.github.com> Signed-off-by: Sawjan Gurung <saw.jan.grg3e@gmail.com> * test: teardown based on scenario tag Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * test: remove expected failure tag from passing scenarios Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * chore: address reviews Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * test: add expected failure tag Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> --------- Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> Signed-off-by: Sawjan Gurung <saw.jan.grg3e@gmail.com> Co-authored-by: Nalem7 <61624650+nabim777@users.noreply.github.com> * tests: replace method `withConsecutive` (#1025) * test: replace method withConsecutive Signed-off-by: nabim777 <nabinalemagar019@gmail.com> * tes: use callback Signed-off-by: nabim777 <nabinalemagar019@gmail.com> * ci: fix some test Signed-off-by: nabim777 <nabinalemagar019@gmail.com> * fix the psalm error Signed-off-by: nabim777 <nabinalemagar019@gmail.com> * cleanup comments Signed-off-by: nabim777 <nabinalemagar019@gmail.com> --------- Signed-off-by: nabim777 <nabinalemagar019@gmail.com> --------- Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> Signed-off-by: Sawjan Gurung <saw.jan.grg3e@gmail.com> Signed-off-by: nabim777 <nabinalemagar019@gmail.com> Co-authored-by: Nalem7 <61624650+nabim777@users.noreply.github.com>
Ashim-Stha
pushed a commit
that referenced
this pull request
Jul 7, 2026
* test: replace method withConsecutive Signed-off-by: nabim777 <nabinalemagar019@gmail.com> * tes: use callback Signed-off-by: nabim777 <nabinalemagar019@gmail.com> * ci: fix some test Signed-off-by: nabim777 <nabinalemagar019@gmail.com> * fix the psalm error Signed-off-by: nabim777 <nabinalemagar019@gmail.com> * cleanup comments Signed-off-by: nabim777 <nabinalemagar019@gmail.com> --------- Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
saw-jan
pushed a commit
that referenced
this pull request
Jul 7, 2026
* test: replace method withConsecutive Signed-off-by: nabim777 <nabinalemagar019@gmail.com> * tes: use callback Signed-off-by: nabim777 <nabinalemagar019@gmail.com> * ci: fix some test Signed-off-by: nabim777 <nabinalemagar019@gmail.com> * fix the psalm error Signed-off-by: nabim777 <nabinalemagar019@gmail.com> * cleanup comments Signed-off-by: nabim777 <nabinalemagar019@gmail.com> --------- Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaced the method
withConsecutivewith its alternatives according to its uses.Related Issue or Workpackage
Screenshots (if appropriate):
Types of changes
Checklist:
CHANGELOG.mdfile