feat: appManagement per helm values#530
Closed
wrenix wants to merge 1 commit into
Closed
Conversation
Signed-off-by: WrenIX <dev.github@wrenix.eu>
provokateurin
left a comment
provokateurin
left a comment
Member
There was a problem hiding this comment.
I'm still not sure if this is a good idea.
| # config of app | ||
| echo "config:" | ||
| {{- range $key, $value := $appConfig.config }} | ||
| /var/www/html/occ config:app:set -n {{ $app }} {{ $key }} --value="{{ $value }}" |
Member
There was a problem hiding this comment.
In some cases you want to be able to specify the value type, otherwise "true" will be set as a string and not as a boolean.
Collaborator
Author
|
I am also not ( in the past i remeber there was an I just like to show the result here. PS: Thank you for the review marathon the last days. I am really sorry about to being so rough / frustrated. |
jessebot
reviewed
Jul 26, 2024
Comment on lines
+166
to
+168
| apps: | ||
| deck: | ||
| enabled: false |
Collaborator
There was a problem hiding this comment.
Suggested change
| apps: | |
| deck: | |
| enabled: false | |
| apps: | |
| deck: | |
| enabled: false |
I think this fixes the indentation issue? 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description of the change
Benefits
Easy Helm-Values management for nextcloud apps
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver.