feat: add form locking mechanism and share edit permission - #2737
Merged
Conversation
Chartman123
force-pushed
the
feat/shareEditPermission
branch
from
May 11, 2025 22:46
f9b7c67 to
fc37acb
Compare
Chartman123
force-pushed
the
feat/shareEditPermission
branch
from
May 11, 2025 22:56
fc37acb to
a3198a4
Compare
Contributor
Chartman123
force-pushed
the
feat/shareEditPermission
branch
11 times, most recently
from
May 13, 2025 23:41
18c3220 to
5c16474
Compare
Closed
Chartman123
force-pushed
the
feat/shareEditPermission
branch
3 times, most recently
from
May 14, 2025 23:19
77df1d9 to
59282d7
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2737 +/- ##
============================================
- Coverage 45.48% 44.12% -1.37%
- Complexity 987 1022 +35
============================================
Files 79 80 +1
Lines 3586 3683 +97
============================================
- Hits 1631 1625 -6
- Misses 1955 2058 +103 🚀 New features to boost your workflow:
|
Chartman123
force-pushed
the
feat/shareEditPermission
branch
3 times, most recently
from
May 15, 2025 09:34
986e8f9 to
a342623
Compare
Chartman123
force-pushed
the
feat/shareEditPermission
branch
4 times, most recently
from
May 16, 2025 23:10
db61925 to
5b0d4a6
Compare
Collaborator
Author
Chartman123
force-pushed
the
feat/shareEditPermission
branch
2 times, most recently
from
May 17, 2025 09:40
a00eca1 to
aaff8fa
Compare
Chartman123
force-pushed
the
feat/shareEditPermission
branch
2 times, most recently
from
June 1, 2025 14:20
ff55376 to
0194dbf
Compare
Chartman123
marked this pull request as ready for review
June 1, 2025 14:30
Chartman123
force-pushed
the
feat/shareEditPermission
branch
from
June 23, 2025 08:41
0194dbf to
63471e4
Compare
- Implemented form locking functionality to prevent concurrent edits. - Updated API responses to include `lockedBy` and `lockedUntil` fields. - Enhanced permission checks to ensure only the form owner can transfer ownership. - Revised documentation to reflect changes in form data structure and API behavior. Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
…for archiving, locking, and ownership transfer Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
Chartman123
force-pushed
the
feat/shareEditPermission
branch
from
June 23, 2025 10:53
d5e9733 to
aa8eca7
Compare
susnux
approved these changes
Aug 13, 2025
susnux
left a comment
Collaborator
There was a problem hiding this comment.
Generally makes sense and looks good!
I would personally have it inverted meaning using lockedSince instead of lockedUntil as then we can change the locking time easier on updates.
But makes not really a difference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lockedByandlockedUntiltogetFormandgetFormseditpermission to shares in frontend (backend already handles it correctly)What should someone with edit permissions be able to do?
closedarchivedpermitAllUsers,showToAllUsers)