File Download limit not decreasing

[alperozturk96]

How to use GitHub

• Please use the 👍 reaction to show that you are affected by the same issue.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

---

Steps to reproduce

1. Create an external share and set download limit
2. Open the external share link in a private/incognito browser window.
3. Download the shared file.
4. Observe the download limit value.

Expected behaviour

The download limit should decrease by one with each file download, reflecting the number of downloads remaining.

Actual behaviour

The download limit remains unchanged after each download, regardless of how many times the file is accessed.

Server configuration

Web server: Apache/Nginx

Database: MySQL/Maria/SQLite/PostgreSQL

PHP version: 8.1/8.2/8.3

Nextcloud version: 31.0.6

Browser

Browser name: Ungoogled Chromium

Browser version: 138.0.7204.100

Operating system: macOS

[printminion-co]

Looks like the PR #48098 broke the app.

• JS part is broken because this lines IONOS-Productivity/nc-server@617af2f3#diff-9caa6c629de928136d4930a365f2973c9091037af3576ea010e1551015c6d816L153-L155

Download URL does not contain the word "download" in URL and this selector document.querySelectorAll('a[href*="/download/"]') has nothing to select. https://github.com/nextcloud/files_downloadlimit/blob/stable31/src/public.ts#L62

The fix would be to switch something like document.querySelectorAll('a[href*="/public.php/dav/files/"]')

Probably server side download counter decrement should be also modified

[come-nc]

For server side counter, ShareLinkAccessedEvent is not emitted anymore because standard dav protocol is used for public links now.
I think something like what was done for activity in https://github.com/nextcloud/server/pull/51458/files#diff-135b9424d29ed1b61040435dc1b3ed88e7d2f4ff85e3324196d9ccfd23678b5e could be done for counting downloads. Not sure how to detect when it’s through a public link though. Maybe from IRequest or something.

[susnux]

yes but also to mention that it was already like this before, we use the DAV endpoint for a quite long time for single file downloads.