Added fetching autoconfig data from Docker secrets#1516
Merged
Conversation
Signed-off-by: Simon Tushev <tushev@users.noreply.github.com>
J0WI
reviewed
Jul 22, 2021
J0WI
left a comment
J0WI
left a comment
Contributor
There was a problem hiding this comment.
I'd check first for the _FILE and then fallback to the env.
Contributor
Author
|
@J0WI Should it be a new pull request or this one? (a novice's question :) |
Contributor
|
You can update this one |
Signed-off-by: Simon Tushev <tushev@users.noreply.github.com>
Contributor
Author
|
Done, also added some info to README.md |
J0WI
approved these changes
Nov 25, 2021
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Nov 29, 2021
Changes: - https///github.com/nextcloud/docker/commit/9059726: Runs update.sh - https///github.com/nextcloud/docker/commit/2857b4b: Added fetching autoconfig data from Docker secrets (https///github.com/nextcloud/docker/pull/1516) - https///github.com/nextcloud/docker/commit/f4dbcf5: add rewrite rule from official docs to nginx examples (https///github.com/nextcloud/docker/pull/1635) - https///github.com/nextcloud/docker/commit/6e54048: Add OVERWRITECLIURL env var (https///github.com/nextcloud/docker/pull/1622) - https///github.com/nextcloud/docker/commit/d82bc95: Switch to new nginx companion registry. (https///github.com/nextcloud/docker/pull/1571)
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Dec 1, 2021
Changes: - https///github.com/nextcloud/docker/commit/5a189c7: Runs update.sh - https///github.com/nextcloud/docker/commit/484b2c5: Alpine 3.15 (https///github.com/nextcloud/docker/pull/1643) - https///github.com/nextcloud/docker/commit/e2dc98d: Nextcloud 23 (https///github.com/nextcloud/docker/pull/1642) - https///github.com/nextcloud/docker/commit/9059726: Runs update.sh - https///github.com/nextcloud/docker/commit/2857b4b: Added fetching autoconfig data from Docker secrets (https///github.com/nextcloud/docker/pull/1516) - https///github.com/nextcloud/docker/commit/f4dbcf5: add rewrite rule from official docs to nginx examples (https///github.com/nextcloud/docker/pull/1635) - https///github.com/nextcloud/docker/commit/6e54048: Add OVERWRITECLIURL env var (https///github.com/nextcloud/docker/pull/1622) - https///github.com/nextcloud/docker/commit/d82bc95: Switch to new nginx companion registry. (https///github.com/nextcloud/docker/pull/1571)
ananace
pushed a commit
to ananace/docker-nextcloud
that referenced
this pull request
May 10, 2024
* Added fetching autoconfig data from Docker secrets Signed-off-by: Simon Tushev <tushev@users.noreply.github.com> * Docker secrets now have priority over ENV variables; improved README.md Signed-off-by: Simon Tushev <tushev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Simon Tushev tushev@users.noreply.github.com
This should solve #1148
This is my first PR. I'm not very familiar with Docker, however, I hope that this solves the issue.
I changed only
.config/autoconfig.php, as far as I can understand these changes should propagate to, say,21.0/apache/config/autoconfig.phpautomatically.Please correct me if I'm wrong.
Another question to consider is the security of
trim(file_get_contents(getenv('MYSQL_DATABASE_FILE')));. Theoretically, it is possible to specify any file, however, the very same approach is used inentrypoint.sh. Both the installation script and Docker secrets should be controlled by a privileged user. I see no issues with this, however, I'm not a security expert and thus I request a second opinion.