fix(print): ensure all images are loaded before opening print dialog#2562
Merged
Conversation
github-project-automation
Bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Productivity team
mejo-
moved this from 🧭 Planning evaluation (don't pick)
to 👀 In review
in 📝 Productivity team
Member
Author
|
The new Playwright test will only succeed after nextcloud/text#8719 (and the corresponding backport PRs) got merged. |
Fixes: #2553 Pass `noLazyImages` to createEditor when loading reader in print view, so images are fetched straight away and not lazy-loaded. Requires nextcloud/text#8719 Also await Text's `onLoaded` callback in setupReader to await the async component loading of MarkdownContentEditor. Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
max-nextcloud
force-pushed
the
fix/print_images
branch
from
June 13, 2026 17:43
7bfa71b to
bb801c5
Compare
max-nextcloud
approved these changes
Jun 18, 2026
max-nextcloud
left a comment
max-nextcloud
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for tackling this. Code looks good.
Tests are a bit verbose handing user and page to many function calls. But figuring out something nice and consistent is for another time i guess.
github-project-automation
Bot
moved this from 👀 In review
to ☑️ Done
in 📝 Productivity team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2553
Pass
noLazyImagesto createEditor when loading reader in print view, so images are fetched straight away and not lazy-loaded.Requires nextcloud/text#8719
Also await Text's
onLoadedcallback in setupReader to await the async component loading of MarkdownContentEditor.🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)