Skip to content

fix(ChattyLLM): Fix disappearing messages #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcelklehr merged 1 commit into from
May 6, 2025
+1 −0
Merged

fix(ChattyLLM): Fix disappearing messages #234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/Controller/ChattyLLMController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,7 @@ public function newMessage(int $sessionId, string $role, string $content, int $t
$message->setRole($role);
$message->setContent($content);
$message->setTimestamp($timestamp);
$message->setSources('[]');

@kyteinsky kyteinsky May 6, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be automatically be populated by the default value, no?

assistant/lib/Migration/Version020500Date20250425125359.php

Line 35 in e1ab390

'default' => '[]',

@marcelklehr marcelklehr May 6, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to test. I'm not sure why that doesn't work.

@marcelklehr marcelklehr May 6, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the message gets returned without refetching it from the db. In the db the default is applied, but not in the message object

@kyteinsky kyteinsky May 6, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah alright that makes sense. Nice one.

$this->messageMapper->insert($message);

if ($firstHumanMessage) {
Expand Down