Skip to content

fix(notifications): Notifier::prepare() threw \InvalidArgumentExcepti… - #249

Merged
nickvergessen merged 1 commit into
mainfrom
bugfix/noid/notification-handling
Jan 8, 2025
Merged

fix(notifications): Notifier::prepare() threw \InvalidArgumentExcepti…#249
nickvergessen merged 1 commit into
mainfrom
bugfix/noid/notification-handling

Conversation

@nickvergessen

Copy link
Copy Markdown
Member

…on which is deprecated

If a user has any notifications this log is generated all the time:

OCA\…\Notification\Notifier::prepare() threw \InvalidArgumentException which is deprecated. Throw \OCP\Notification\UnknownNotificationException when the notification is not known to your notifier and otherwise handle all \InvalidArgumentException yourself.

…on which is deprecated

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen self-assigned this Dec 20, 2024
@nickvergessen
nickvergessen merged commit 26f2929 into main Jan 8, 2025
@nickvergessen
nickvergessen deleted the bugfix/noid/notification-handling branch January 8, 2025 10:03
@julien-nc julien-nc mentioned this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants