Use localID from webdav by tobiasKaminsky · Pull Request #8643 · nextcloud/android

tobiasKaminsky · 2021-06-30T06:19:21Z

Needs nextcloud/android-library#651
After:

Use Room for filelist table reads #11098

do not use localID (which might make sense in terms of federation)
or expose unique server id via capabilities
or have server return localID via webdav

EDIT: using localId via webdav is the solution!

E.g. my instance has 14 chars for unique id @juliushaertl
~~To handle this properly we need uniqe id exposed via registered capability, if this is ok for you.~~

Fixes #9826
Fixes #10261

nextcloud-android-bot · 2021-06-30T06:25:09Z

stable-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/1642-Unit-stable-06-24

nextcloud-android-bot · 2021-06-30T06:25:45Z

master-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/1642-Unit-master-06-25

juliusknorr · 2021-06-30T08:19:45Z

EDIT: using localId via webdav is the solution!

yep sounds like the better approach 👍

nextcloud-android-bot · 2021-06-30T10:15:03Z

master-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/1645-Unit-master-10-14

nextcloud-android-bot · 2021-06-30T10:15:04Z

stable-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/1645-Unit-stable-10-14

nextcloud-android-bot · 2021-07-02T07:29:43Z

master-Unit test failed, but no output was generated. Maybe a preliminary stage failed.

nextcloud-android-bot · 2021-07-07T09:28:09Z

stable-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/1689-Unit-stable-09-27

nextcloud-android-bot · 2021-07-07T09:29:32Z

master-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/1689-Unit-master-09-28

nextcloud-android-bot · 2021-07-07T09:37:50Z

Codacy

Lint

Type	master	PR
Warnings	227	227
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	27
Correctness Warnings	51
Internationalization Warnings	9
Multithreaded correctness Warnings	9
Performance Warnings	72
Security Warnings	40
Dodgy code Warnings	97
Total	305

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	27
Correctness Warnings	51
Internationalization Warnings	9
Multithreaded correctness Warnings	9
Performance Warnings	72
Security Warnings	40
Dodgy code Warnings	97
Total	305

Android-library is not set to master branch in build.gradle

tobiasKaminsky · 2022-12-06T07:16:21Z

/rebase

tigermick · 2022-12-06T12:23:04Z

hi,
I have a problem here : #10261
and your Nextcloud QA release here : https://www.kaminsky.me/nc-dev/android-artifacts/8643.apk fix my problem

AlvaroBrey · 2022-12-19T15:13:34Z

/rebase

AlvaroBrey · 2023-01-09T16:36:54Z

/rebase

AlvaroBrey · 2023-01-11T14:11:45Z

/drone/src/app/src/androidTest/java/com/nextcloud/client/EndToEndRandomIT.java:656: error: cannot find symbol
--
712 | assertTrue(new DeletePrivateKeyOperation().execute(client).isSuccess());

Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com> Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

…entIT Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>

codecov · 2023-01-18T13:21:37Z

Codecov Report

Merging #8643 (daafa24) into master (0b3707c) will decrease coverage by 0.18%.
The diff coverage is 51.72%.

❗ Current head daafa24 differs from pull request most recent head 0d2dc8e. Consider uploading reports for the commit 0d2dc8e to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #8643      +/-   ##
============================================
- Coverage     31.58%   31.40%   -0.18%     
+ Complexity     3400     3383      -17     
============================================
  Files           566      566              
  Lines         41601    41613      +12     
  Branches       5628     5629       +1     
============================================
- Hits          13138    13070      -68     
- Misses        26508    26593      +85     
+ Partials       1955     1950       -5

Impacted Files	Coverage Δ
...com/nextcloud/client/database/NextcloudDatabase.kt	`100.00% <ø> (ø)`
...ain/java/com/nextcloud/client/media/LoadUrlTask.kt	`0.00% <0.00%> (ø)`
...src/main/java/com/nextcloud/client/media/Player.kt	`0.00% <0.00%> (ø)`
...loud/android/datamodel/ThumbnailsCacheManager.java	`35.14% <0.00%> (-5.76%)`	⬇️
...ain/java/com/owncloud/android/db/ProviderMeta.java	`100.00% <ø> (ø)`
...ncloud/android/files/StreamMediaFileOperation.java	`0.00% <0.00%> (ø)`
...cloud/android/operations/CommentFileOperation.java	`0.00% <0.00%> (ø)`
...operations/RemoveRemoteEncryptedFileOperation.java	`66.00% <ø> (ø)`
.../android/operations/RichDocumentsUrlOperation.java	`0.00% <0.00%> (ø)`
...m/owncloud/android/services/OperationsService.java	`37.36% <0.00%> (ø)`
... and 30 more

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

tobiasKaminsky · 2023-01-19T08:22:26Z

Library merged, so let us merge this asap.

nextcloud-android-bot · 2023-01-19T09:46:08Z

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/7442-IT-master-09-45

github-actions · 2023-01-19T09:51:35Z

blue-Light-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/8643-Screenshot-blue-Light-09-51

github-actions · 2023-01-19T09:54:56Z

Codacy

Lint

Type	master	PR
Warnings	76	76
Errors	0	0

SpotBugs

Category	Base	New
Bad practice	27	27
Correctness	44	44
Dodgy code	335	335
Internationalization	9	9
Multithreaded correctness	9	9
Performance	58	58
Security	18	18
Total	500	500

github-actions · 2023-01-19T10:01:05Z

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/8643.apk

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

szaimen · 2023-01-19T14:24:24Z

🎉🎉🎉

tobiasKaminsky added the 2. developing label Jun 30, 2021

tobiasKaminsky commented Jun 30, 2021

View reviewed changes

Comment thread src/main/java/com/owncloud/android/datamodel/OCFile.java Outdated

tobiasKaminsky mentioned this pull request Jun 30, 2021

Retrieve localId via webdav nextcloud/android-library#651

Merged

tobiasKaminsky changed the title ~~Compute localId from remote id with unique server id~~ Use localID from webdav Jun 30, 2021

tobiasKaminsky force-pushed the localID_2 branch from 173e7a0 to 21af2e9 Compare June 30, 2021 10:09

tobiasKaminsky force-pushed the localID_2 branch from 21af2e9 to a77ddf1 Compare July 2, 2021 07:27

tobiasKaminsky force-pushed the localID_2 branch from a77ddf1 to 255e0cf Compare December 2, 2022 11:03

tobiasKaminsky commented Dec 2, 2022

View reviewed changes

Comment thread app/src/main/java/com/nextcloud/client/database/NextcloudDatabase.kt Outdated

tobiasKaminsky added 3. to review and removed 2. developing labels Dec 2, 2022

tobiasKaminsky requested a review from AlvaroBrey December 2, 2022 11:11

AlvaroBrey requested changes Dec 2, 2022

View reviewed changes

tobiasKaminsky force-pushed the localID_2 branch from b104e3d to 5d25069 Compare December 2, 2022 13:43

AlvaroBrey approved these changes Dec 2, 2022

View reviewed changes

nextcloud-command force-pushed the localID_2 branch from 167b00d to e15f674 Compare December 6, 2022 07:17

tobiasKaminsky mentioned this pull request Dec 6, 2022

impossible to watch video on stream #10261

Closed

tobiasKaminsky force-pushed the localID_2 branch 2 times, most recently from a01b07f to 25b6a52 Compare December 6, 2022 10:00

tobiasKaminsky force-pushed the localID_2 branch from 25b6a52 to c1655d8 Compare December 7, 2022 07:43

nextcloud-command force-pushed the localID_2 branch from 116a532 to bf76ef3 Compare December 19, 2022 15:14

AlvaroBrey mentioned this pull request Dec 19, 2022

Android app fails to play media files (music) from bind-mounted folder #9826

Closed

AlvaroBrey reviewed Dec 20, 2022

View reviewed changes

Comment thread app/src/main/java/com/owncloud/android/datamodel/OCFile.java

AlvaroBrey force-pushed the localID_2 branch from 6de62d4 to 3eb4cc6 Compare December 20, 2022 11:54

AlvaroBrey approved these changes Dec 20, 2022

View reviewed changes

AlvaroBrey force-pushed the localID_2 branch from 3eb4cc6 to 08077bd Compare January 9, 2023 16:38

tobiasKaminsky force-pushed the localID_2 branch from 08077bd to 944a5b7 Compare January 17, 2023 08:13

tobiasKaminsky and others added 5 commits January 18, 2023 12:23

use localID everywhere

b78e991

Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com> Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

fix test -> we need to have a 8 digit remote id for proper testing

b293ece

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Changes after rebase

0b33eaf

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Fix wrong initialization for FileDataStorageManagerContentProviderCli…

0287e34

…entIT Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>

Fix tets that need a 8-length remote ID

daafa24

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>

AlvaroBrey force-pushed the localID_2 branch from 944a5b7 to daafa24 Compare January 18, 2023 11:23

revert to use master library

0d2dc8e

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

AlvaroBrey force-pushed the localID_2 branch from b73800f to 0d2dc8e Compare January 19, 2023 09:31

AlvaroBrey merged commit 37b85cf into master Jan 19, 2023

delete-merged-branch Bot deleted the localID_2 branch January 19, 2023 10:19

bohwaz mentioned this pull request Jun 11, 2023

the last nexcloud cliend from f-droid crashes kd2org/karadav#39

Closed

This was referenced Jan 30, 2025

use local id from webdav #10011

Closed

Use fileId instead of relying on remoteID #8566

Closed

Uh oh!

Uh oh!

Conversation

tobiasKaminsky commented Jun 30, 2021 • edited by AlvaroBrey Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

nextcloud-android-bot commented Jun 30, 2021

Uh oh!

nextcloud-android-bot commented Jun 30, 2021

Uh oh!

juliusknorr commented Jun 30, 2021

Uh oh!

nextcloud-android-bot commented Jun 30, 2021

Uh oh!

nextcloud-android-bot commented Jun 30, 2021

Uh oh!

nextcloud-android-bot commented Jul 2, 2021

Uh oh!

nextcloud-android-bot commented Jul 7, 2021

Uh oh!

nextcloud-android-bot commented Jul 7, 2021

Uh oh!

nextcloud-android-bot commented Jul 7, 2021

Codacy

Lint

SpotBugs (new)

SpotBugs (master)

Android-library is not set to master branch in build.gradle

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tobiasKaminsky commented Dec 6, 2022

Uh oh!

tigermick commented Dec 6, 2022

Uh oh!

AlvaroBrey commented Dec 19, 2022

Uh oh!

Uh oh!

AlvaroBrey commented Jan 9, 2023

Uh oh!

AlvaroBrey commented Jan 11, 2023

Uh oh!

codecov Bot commented Jan 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tobiasKaminsky commented Jan 19, 2023

Uh oh!

nextcloud-android-bot commented Jan 19, 2023

Uh oh!

github-actions Bot commented Jan 19, 2023

Uh oh!

github-actions Bot commented Jan 19, 2023

Codacy

Lint

SpotBugs

Uh oh!

github-actions Bot commented Jan 19, 2023

Uh oh!

szaimen commented Jan 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

tobiasKaminsky commented Jun 30, 2021 •

edited by AlvaroBrey

Loading

codecov Bot commented Jan 18, 2023 •

edited

Loading