Skip to content

[stable-3.22] Fix keyboard opening on dialogs causing squished dialogs in Material3#10963

Merged
AlvaroBrey merged 1 commit into
stable-3.22from
backport/10962/stable-3.22
Oct 31, 2022
Merged

[stable-3.22] Fix keyboard opening on dialogs causing squished dialogs in Material3#10963
AlvaroBrey merged 1 commit into
stable-3.22from
backport/10962/stable-3.22

Conversation

@backportbot-nextcloud

Copy link
Copy Markdown

backport of #10962

Use the proper InputMethodManager service to allow dialogs to correctly detect keyboard opening, and adjust margins properly

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
@github-actions

Copy link
Copy Markdown

Lint

Typestable-3.22PR
Warnings8484
Errors00

SpotBugs

CategoryBaseNew
Bad practice2828
Correctness4646
Dodgy code342342
Internationalization99
Multithreaded correctness99
Performance5858
Security2828
Total520520

@github-actions

Copy link
Copy Markdown

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10963.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@codecov

codecov Bot commented Oct 31, 2022

Copy link
Copy Markdown

Codecov Report

Merging #10963 (1df9d30) into stable-3.22 (2f99373) will increase coverage by 0.04%.
The diff coverage is 0.00%.

Additional details and impacted files
@@                Coverage Diff                @@
##             stable-3.22   #10963      +/-   ##
=================================================
+ Coverage          31.34%   31.38%   +0.04%     
- Complexity          3282     3293      +11     
=================================================
  Files                543      544       +1     
  Lines              41001    40994       -7     
  Branches            5685     5678       -7     
=================================================
+ Hits               12850    12865      +15     
+ Misses             26251    26225      -26     
- Partials            1900     1904       +4     
Impacted Files Coverage Δ
...log/ChooseRichDocumentsTemplateDialogFragment.java 0.00% <0.00%> (ø)
.../android/ui/dialog/ChooseTemplateDialogFragment.kt 0.00% <0.00%> (ø)
.../android/ui/dialog/CreateFolderDialogFragment.java 0.00% <0.00%> (ø)
...loud/android/ui/dialog/MultipleAccountsDialog.java 0.00% <0.00%> (ø)
...owncloud/android/ui/dialog/NoteDialogFragment.java 0.00% <0.00%> (ø)
...ud/android/ui/dialog/RenameFileDialogFragment.java 0.00% <0.00%> (ø)
...oid/ui/dialog/RenamePublicShareDialogFragment.java 0.00% <0.00%> (ø)
...android/ui/dialog/SharePasswordDialogFragment.java 0.00% <0.00%> (ø)
...n/java/com/owncloud/android/utils/KeyboardUtils.kt 0.00% <0.00%> (ø)
...oud/android/operations/RefreshFolderOperation.java 76.32% <0.00%> (-0.71%) ⬇️
... and 13 more

@AlvaroBrey AlvaroBrey merged commit 8efe5e5 into stable-3.22 Oct 31, 2022
@delete-merged-branch delete-merged-branch Bot deleted the backport/10962/stable-3.22 branch October 31, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant