Conversation
kesselb
approved these changes
Jul 16, 2026
susnux
added a commit
to nextcloud/server
that referenced
this pull request
Jul 16, 2026
ref: nextcloud-libraries/nextcloud-e2e-test-server#1051 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Simplify the logic for custom apps folder: Always use the `apps` folder just for the shipped apps, and use the custom `apps-writable` folder for custom mounted apps. This should resolve issues in some cases like on server when mounting the whole `apps` folder but sometimes not cloning apps. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
changed the title
apps_writableapps-writable
Contributor
Author
|
(fixed tests and adjusted to suggestion of @kesselb to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify the logic for custom apps folder:
Always use the
appsfolder just for the shipped apps, and use the customapps_writablefolder for custom mounted apps.This should resolve issues in some cases like on server when mounting the whole
appsfolder but sometimes not cloning apps.🤖 AI (if applicable)