Skip to content

fix: reorder SPDX headers - #961

Closed
Antreesy wants to merge 1 commit into
mainfrom
fix/noid/spdx-order
Closed

fix: reorder SPDX headers#961
Antreesy wants to merge 1 commit into
mainfrom
fix/noid/spdx-order

Conversation

@Antreesy

Copy link
Copy Markdown

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

- headers in incorrect order caught in .js.map files during reuse lint CI as incorrect expressions

Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
Antreesy requested review from ShGKme and susnux August 10, 2026 11:41
@Antreesy Antreesy self-assigned this Aug 10, 2026
@Antreesy Antreesy added bug Something isn't working 3. to review AI assisted This PR contains AI-assisted commits labels Aug 10, 2026
@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.30%. Comparing base (d77aa1a) to head (137fc40).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #961   +/-   ##
=======================================
  Coverage   87.30%   87.30%           
=======================================
  Files           5        5           
  Lines          63       63           
  Branches       19       19           
=======================================
  Hits           55       55           
  Misses          8        8           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@susnux

susnux commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

I think the real fix here is for logreader to set the vite config option extractLicenseInformation to { includeSourceMaps: true }.


docs telling (in examples), that license-identifier should come last in the list of headers: https://reuse.readthedocs.io/en/v0.7.0/usage.html?highlight=license%20expressions#lint

IMHO it should be the opposite, because you add the license, then an copyright owner. Later you add another copyright owner etc so becoming a list rather you have to "scroll" for the license.

 # SPDX-License-Identifier: MIT
 # SPDX-FileCopyrightText: 2019 Jane Doe
+# SPDX-FileCopyrightText: 2020 Joe Doe

@Antreesy

Copy link
Copy Markdown
Author

This only adds .license files, but does not modify .map itself:
image
Does it guaranteee maps will be skipped by linter?

@susnux

susnux commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Does it guaranteee maps will be skipped by linter?

Yes .license files override parsing of those files.

@ShGKme

ShGKme commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

docs telling (in examples), that license-identifier should come last in the list of headers

As I understand, this is just an example. It doesn't validate this order.
And it is not mentioned in the spec: https://spdx.github.io/spdx-spec/v2.3/file-tags/

@Antreesy

Copy link
Copy Markdown
Author

Ok, sorry for the noise then

@Antreesy Antreesy closed this Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review AI assisted This PR contains AI-assisted commits bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants