CoreNEURON GPU build integration improvements - #707
Merged
Conversation
- For GPU we need to build CoreNEURON statically. Those libraries needs to be linked to special directly (dlopen is not supported) - CoreNEURON now prepares necessary link library flag for NEURON - If user specify -coreneuron as an argument to nrnivmodl then necessary coreneuron libraries are linked to special directly.
pramodk
force-pushed
the
pramodk/gpu-build-improvements
branch
from
August 15, 2020 18:06
2c04427 to
506fc23
Compare
pramodk
force-pushed
the
pramodk/gpu-build-improvements
branch
from
August 15, 2020 21:33
2673319 to
b9ec0da
Compare
pramodk
marked this pull request as ready for review
August 16, 2020 13:01
pramodk
marked this pull request as draft
August 16, 2020 13:02
This was referenced Aug 16, 2020
pramodk
requested review from
alexsavulescu and
nrnhines
and removed request for
nrnhines
August 18, 2020 15:10
pramodk
marked this pull request as ready for review
August 18, 2020 15:10
alexsavulescu
approved these changes
Aug 18, 2020
alexsavulescu
left a comment
alexsavulescu
left a comment
Member
There was a problem hiding this comment.
A couple of style suggestions, otherwise LGTM
nrnhines
approved these changes
Aug 18, 2020
nrnhines
left a comment
nrnhines
left a comment
Member
There was a problem hiding this comment.
Great! This is very great advance for usability.
olupton
pushed a commit
that referenced
this pull request
Dec 7, 2022
- NewtonSpace** was copied to GPU instead of NewtonSpace* - MechInstance variable pointer from the device was not setup in the membrane list structure - In case of derivimplicit solver, deriv1_advance flag was not updated on the GPU device fixes #707
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needs to be linked to special directly (dlopen is not supported)
necessary coreneuron libraries are linked to special directly.
Corresponding to BlueBrain/CoreNeuron#373