Bump minimum supported CMake version to 3.15.0 - #1408
Merged
Conversation
* target consistency across libraries, i.e CoreNEURON + GPU needs 3.15
Codecov Report
@@ Coverage Diff @@
## master #1408 +/- ##
=======================================
Coverage 33.07% 33.07%
=======================================
Files 569 569
Lines 108957 108957
=======================================
Hits 36037 36037
Misses 72920 72920 Continue to review full report at Codecov.
|
pramodk
requested changes
Aug 18, 2021
pramodk
left a comment
pramodk
left a comment
Member
There was a problem hiding this comment.
Could you check the documentation / readme updates in the installation section?
olupton
approved these changes
Aug 19, 2021
olupton
left a comment
olupton
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, just one nitpick.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs: BlueBrain/CoreNeuron#612, BlueBrain/nmodl#718