BaseControl: disabled controls are always omitted

[martinknor]

No description provided.

[dg]

Please change commit message to something like 'BaseControl: disabled controls are always omitted'

[chemix]

ping @martinknor can you please update commit message

[dg]

Thanks

[enumag]

@dg Are you aware that this is BC break? I actually used ->setDisabled(true)->setOmitted(false) once (don't remember where or why though).

[dg]

Yes, it can be a BC break. In what case do you use it?

[enumag]

@dg It is an input that is disabled by default but sometimes enabled by javascript. I can easily refactor it to get around this of course. Just wanted to point out the BC break fact.

[pavelkouril]

What positive behavior will this change bring (and does it justify the BC break)?

Also, @enumag, how do you get around this BC break to keep the same functionality?

[matej21]

You can find discussion here: https://gitter.im/nette/nette/cs?at=55c0a9ac7a6037e67c597569 (czech only)
tl;dr; before this, when you called ->setDisabled(TRUE)->setDisabled(FALSE) then a control was still omitted

[matej21]

fixed in #116

[enumag]

@pavelkouril I'd probably just reverse the behavior - the field would be enabled by default and disabled by javascript in some cases. PR #116 should remove the BC break though.