Redirect doesn't work if there's a leading space in the address

[sean-roberts]

Describe the bug

if I have a leading space in a redirect, the redirect doesn't work.

This was obviously an issue caused by user error but I unexpectedly lost a lot of time on this cursed space. I believe this would be a quick win to resolve these typos issues by trimming the URI as they are known to not match the URI spec. If there is more nuance here than I am unaware of (most likely), then we should be able to trim reliably if the redirect trimmed redirect starts with ^http[s]?:\/\/

Steps to reproduce

Use a leading space in the to field of a redirect.

[[redirects]]
  from = "/test"
  to = " https://www.netlify.com"
  status = 200

Configuration

see steps to repro

Environment

System:
    OS: macOS 12.4
    CPU: (10) arm64 Apple M1 Pro
    Memory: 3.74 GB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.13.1 - /opt/homebrew/opt/nvm/versions/node/v16.13.1/bin/node
    Yarn: 1.22.17 - /opt/homebrew/opt/nvm/versions/node/v16.13.1/bin/yarn
    npm: 8.1.2 - /opt/homebrew/opt/nvm/versions/node/v16.13.1/bin/npm
  npmGlobalPackages:
    netlify-cli: 10.3.1

[deepto98]

Can I pick this up? Can you point me to the relevant files, I would need to work on?

[tinfoil-knight]

Edit: This comment is not relevant anymore. See #4707 (comment) instead.

---

The issue seems to be occurring here when the provided URL doesn't match the pattern for external redirects due to the extra space.

cli/src/utils/proxy.js

Lines 220 to 222 in 8b0539d

	if (isExternal(match)) {
	return proxyToExternalUrl({ req, res, dest, destURL })
	}

You can also look into the onRequest function in the same file which handles all requests to the netlify dev server to handle the url early on.

cli/src/utils/proxy.js

Lines 407 to 411 in 8b0539d

	const onRequest = async ({ addonsUrls, edgeFunctionsProxy, functionsServer, proxy, rewriter, settings }, req, res) => {
	req.originalBody = ['GET', 'OPTIONS', 'HEAD'].includes(req.method)
	? null
	: await createStreamPromise(req, BYTES_LIMIT)

[tinfoil-knight]

@minivan

This issue is blocked until production also has the same behaviour because we don't want feature disparity b/w the CLI & the production environment.

---

Also, note for contributors:

This issue should be fixed in https://github.com/netlify/netlify-redirect-parser

Entrypoint in netlify/cli is

cli/src/utils/redirects.js

Lines 11 to 15 in ac4e0e4

	const { errors, redirects } = await parseAllRedirects({
	redirectsFiles,
	netlifyConfigPath: configPath,
	minimal: false,
	})

[rajatsingh23]

I would like to work on it. Can I know how to reproduce the issue?