Skip to content

feat(): JWT_MODULE_OPTIONS set to be optional - #955

Merged
kamilmysliwiec merged 1 commit into
nestjs:masterfrom
flamewow:feat/plain_module_import
May 19, 2022
Merged

feat(): JWT_MODULE_OPTIONS set to be optional#955
kamilmysliwiec merged 1 commit into
nestjs:masterfrom
flamewow:feat/plain_module_import

Conversation

@flamewow

Copy link
Copy Markdown
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the new behavior?

JWT_MODULE_OPTIONS is now optional, so we can import the module as

...
   imports: [JwtModule, ],
...

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@flamewow
flamewow marked this pull request as ready for review May 18, 2022 13:58
@flamewow
flamewow force-pushed the feat/plain_module_import branch from 0f92851 to 78c9bb3 Compare May 18, 2022 15:22
@flamewow flamewow changed the title made JWT_MODULE_OPTIONS an optional inject feat(): JWT_MODULE_OPTIONS set to be optional May 18, 2022
@kamilmysliwiec
kamilmysliwiec merged commit c5c2939 into nestjs:master May 19, 2022
@kamilmysliwiec

Copy link
Copy Markdown
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants