Allow secret to be passed as an option to sign and verify - #336
Merged
Conversation
This allows you to pass the `secret` property in the options of sign, signAsync, verify and verifyAsync. It does not override a secretOrKeyProvider though only the secret passed into the JwtModule. Resolves #302
nartc
reviewed
Jul 5, 2020
| sign(payload: string | Buffer | object, options?: JwtSignOptions): string { | ||
| const signOptions = this.mergeJwtOptions( | ||
| options, | ||
| { ...options }, |
There was a problem hiding this comment.
is this spread for some TypeScript error?
Contributor
Author
There was a problem hiding this comment.
I spread it because I needed a copy of the object so I could remove the secret property in the mergeJwtOptions function without it affecting the original object.
Member
|
Thank you! |
Contributor
|
Hi @kamilmysliwiec , do you think this should also be possible to override I think in production many people (including me) using RSA key instead Thank you |
Member
|
@maitrungduc1410 would you like to create a PR for this? |
Contributor
|
@kamilmysliwiec I just created PR #401 for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
There is currently no way to override the secret passed in from the module. This makes it difficult if you want to use a different secret for two different sign calls for example and
access tokenand arefresh tokenIssue Number: #302
What is the new behavior?
The new behaviour allows you to pass a secret in to the sign, signAsync, verify and verifyAsync methods to override the secret from the one passed into the module. It does not override the
secretOrKeyProviderthough.Does this PR introduce a breaking change?
Other information
It's possible you may want the secret to override the
secretOrKeyProviderbut I wasn't sure. Happy to tweak this PR if you'd prefer it that way.