Return partial as engine with given view_path - #601
Merged
Conversation
There was problem with `view_path` method. This method under normal circumstances will returns `@_view_path` instance variable. Here comes an interesting behavior of ruby ```ruby def view_path true end view_path = nil || view_path view_path # => nil ``` Ruby will initialize non-existed local_variable and override the method with the same name. So there is no way to create engine with given `view_path`.
Contributor
Author
|
Related #599 |
DouweM
added a commit
that referenced
this pull request
Dec 5, 2014
Return partial as engine with given view_path
Collaborator
|
Thanks, I prefer this implementation to that of #599. Merged! |
Contributor
Author
|
@DouweM thanks!:-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was problem with
view_pathmethod. This method under normalcircumstances will returns
@_view_pathinstance variable. Here comesan interesting behavior of ruby
Ruby will initialize non-existed local_variable and override the
method with the same name. So there is no way to create engine with
given
view_path.