[Snyk] Upgrade sirv-cli from 1.0.11 to 1.0.14 - #677
Conversation
Snyk has created this PR to upgrade sirv-cli from 1.0.11 to 1.0.14. See this package in npm: sirv-cli See this project in Snyk: https://app.snyk.io/org/newtonombese1/project/823e32d5-b340-4e91-8abe-047fc5c6b4bc?utm_source=github&utm_medium=referral&page=upgrade-pr
Summary of ChangesHello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the upgrade of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request, automatically generated by Snyk, upgrades sirv-cli from 1.0.11 to 1.0.14. This is a patch update that includes several bug fixes, including one for parsing boolean CLI options which is relevant to your start script.
While the change is correct, I've suggested a further upgrade to the latest major version of sirv-cli (2.0.2) for better performance and more recent updates. Please see the specific comment for details on the required changes if you choose to proceed with that.
| "@fortawesome/free-solid-svg-icons": "^5.15.2", | ||
| "bulma": "^0.9.2", | ||
| "sirv-cli": "^1.0.11", | ||
| "sirv-cli": "^1.0.14", |
There was a problem hiding this comment.
While this upgrade to 1.0.14 is good, this version is from August 2021. I recommend upgrading to the latest major version, 2.0.2, which was released in February 2022. This will give you a smaller, faster sirv-cli with the latest fixes.
sirv-cli@2.x has some breaking changes. Notably, the --dev flag is removed and is now the default behavior. If you upgrade, you'll need to remove this flag from your serve function in rollup.config.js.
Here's what you'd need to do:
- Accept the code suggestion below.
- Run
npm installto updatepackage-lock.json. - In
svelte-app/rollup.config.js, modify theservefunction to remove the--devargument:
// svelte-app/rollup.config.js:80
server = require('child_process').spawn('npm', ['run', 'start', '--'], {
stdio: ['ignore', 'inherit', 'inherit'],
shell: true
});| "sirv-cli": "^1.0.14", | |
| "sirv-cli": "^2.0.2", |
Snyk has created this PR to upgrade sirv-cli from 1.0.11 to 1.0.14. See this package in npm: sirv-cli See this project in Snyk: https://app.snyk.io/org/mohammadnewton/project/c10961dd-40e2-47eb-94a1-0e52e1fe3b6d?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade sirv-cli from 1.0.11 to 1.0.14.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 3 versions ahead of your current version.
The recommended version was released 4 years ago.
Release notes
Package name: sirv-cli
-
1.0.14 - 2021-08-14
- (
-
1.0.13 - 2021-08-13
-
-
1.0.12 - 2021-05-24
- (sirv-cli): Ensure
- (sirv): Bump
- Adjust GitHub Action env setup (#109): f2ae0f5
- Update Github Action image(s) and Node versions: 9334dfc, cf2de81, c7e0a20
- Add test for filename with space (#102): ede9189
-
1.0.11 - 2021-01-30
- (
from sirv-cli GitHub release notesChores
sirv): Bump@ polka/urlto take advantage of this fixPatches
(
sirv) Only usereq.pathif hasreq._decodedflag exists (#82):The
req._decodedcheck was added & should have always been in there, since this wassirv's way of preventing duplicatedecodeURIComponentcalls. However, this was only true when it received a request from apolka@nextapp, since Polka was previously writing the decoded value toreq.path– this changed withpolka@v1.0.0-next.16Now that the latest
polka@next(and Express) doesn't decode automatically anymore,req.pathisn't trustworthy on its own. It needsreq._decodedto be there too in order to trust it.This combo-check is backwards compatible for
polka@nextusers who don't upgrade and will unblock Express users for the first time, who have always had a "raw"req.pathvalue set.Patches
booleanoptions are parsed as booleans (#97): 8ebca7c@ polka/urldependency version: 7c5162aChores
Thank you @ samccone!
Patches
sirv) AddVaryheader when gzip or brotli is in use (#95): 86e6733Thank you @ istarkov~!
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: