refactor: permissionsをClaude GitHub App前提の最小限に簡素化 - #7
Merged
Conversation
github_tokenを省略するとclaude-code-actionがClaude GitHub Appのトークンを使うため、 ワークフローのpermissionsブロックが制約するgithub.tokenには最小限の権限があれば十分です。 github_tokenを明示する場合は呼び出し側で追加権限を付与する必要がある旨を記載しました。
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
There was a problem hiding this comment.
Pull request overview
Claude GitHub App が発行するトークンをデフォルト利用する前提で、ワークフロー/ドキュメント上の permissions 設定を最小限に寄せ、github_token を明示する場合の注意点を追記するPRです。
Changes:
- READMEの permissions 説明とサンプルを最小権限に簡素化
- Reusable workflow / サンプル workflow の
permissionsを最小構成に更新 github_token明示時に追加権限が必要な旨をREADME・workflowコメントに追記
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| README.md | permissions の推奨設定を最小権限に変更し、github_token 明示時の注意を追記 |
| .github/workflows/review.yml | reusable workflow の permissions を最小化し、コメントを更新 |
| .github/workflows/kyosei.yml | 呼び出し側ワークフローの permissions を最小化し、コメントを更新 |
Composite Actionでは`github_token`を渡せるのにReusable Workflowでは渡せない制限があったため、 secretsとして追加してComposite Actionにそのまま受け渡すようにしました。
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github_tokenを省略するとclaude-code-actionがClaude GitHub Appのトークンを使うため、 ワークフローのpermissionsブロックが制約するgithub.tokenには最小限の権限があれば十分です。 github_tokenを明示する場合は呼び出し側で追加権限を付与する必要がある旨を記載しました。