Chunk vcache_mset to avoid bit64 as.list protection overflow#240
Open
jefferis wants to merge 2 commits into
Open
Chunk vcache_mset to avoid bit64 as.list protection overflow#240jefferis wants to merge 2 commits into
jefferis wants to merge 2 commits into
Conversation
bit64::as.list.integer64() PROTECTs once per element in a C loop (r-lib/bit64#346), overflowing R's protection stack for integer64 vectors longer than ~R_PPStackSize. This surfaced as a protection stack overflow when flywire_updateids() cached a large batch of supervoxel->root id mappings. vcache_mset() now converts via as_list_chunked(), which splits into 10k blocks so each as.list() stays under the limit regardless of the installed bit64 version.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #240 +/- ##
==========================================
+ Coverage 58.73% 58.76% +0.03%
==========================================
Files 44 44
Lines 5901 5913 +12
==========================================
+ Hits 3466 3475 +9
- Misses 2435 2438 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Fixes R CMD check WARNING: undocumented argument 'invert_surf' in flywire_partners.Rd.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bit64::as.list.integer64() PROTECTs once per element in a C loop (r-lib/bit64#346), overflowing R's protection stack for integer64 vectors longer than ~R_PPStackSize. This surfaced as a protection stack overflow when flywire_updateids() cached a large batch of supervoxel->root id mappings.
vcache_mset() now converts via as_list_chunked(), which splits into 10k blocks so each as.list() stays under the limit regardless of the installed bit64 version.