Release Candidate 1.7.5#859
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #859 +/- ##
==========================================
- Coverage 72.06% 72.06% -0.01%
==========================================
Files 761 761
Lines 91123 91123
Branches 7289 7287 -2
==========================================
- Hits 65668 65664 -4
- Misses 25455 25459 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…al config files to make it easier/clearer.
…al config files to make it easier/clearer... part 2.
|
Tested the major changes and they all work as expected. |
msuder
left a comment
There was a problem hiding this comment.
I finished testing and reviewing the changed files. Everything looks good and I approve this pull request.
mattilynwalker
left a comment
There was a problem hiding this comment.
I verified all scenarios - all worked as expected.
One note would be in older scenarios such as Low Power, underscores should be updated to dashes: cfg/nos3_mission.xml is now no longer valid as it is accessible via cfg/nos3-mission.xml. Also, cfg/sim/nos3-simulator.xml should be changed to cfg/sims/nos3-simulator.xml (insert "s" after "sims") located under Low Power Step 1: Scenario Setup.
I am approving this pull request otherwise.
jennifer-opalko
left a comment
There was a problem hiding this comment.
All scenarios worked as expected. The only note that may be confusing is in Scenario_Nominal_Ops.md, the Science_Mode_cmd.png has target as MGR and not MGR_RADIO like the scenario text says (could be slightly misleading for some). Approving otherwise.
Release 1.7.5: Pull the branch below to review NOS3. If any changes please push to the 858-RC_1.7.5 branch
Branch: https://github.com/nasa/nos3/tree/858-RC_1.7.5
Confirm nominal nos3 operations, scenarios, and verify major changes since last release.
Major Changes include: (Recent changes to verify along with normal NOS3 operations)
Need to confirm:
Reviews:
Note: Will be merging changes into dev not main. base is main to review changes for Release Candidate branch
Need to merge submods RC branches into dev:
radio
cryptolib