Skip to content

Rename LinuxUartDriver to PosixUartDriver and update restrictions - #5811

Open
thomas-bc wants to merge 4 commits into
nasa:develfrom
JPL-Devin:devin/1788285681-posix-uart-driver
Open

Rename LinuxUartDriver to PosixUartDriver and update restrictions#5811
thomas-bc wants to merge 4 commits into
nasa:develfrom
JPL-Devin:devin/1788285681-posix-uart-driver

Conversation

@thomas-bc

@thomas-bc thomas-bc commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator
Related Issue(s)
Has Unit Tests (y/n)
Documentation Included (y/n)
Generative AI was used in this contribution (y/n)

Change Description

Fixes #5698

  • Renamed Drv/LinuxUartDriver to Drv/PosixUartDriver and changed restrict_platforms(Linux Darwin) to restrict_platforms(Posix).
  • Updated doc references

thomas-bc and others added 2 commits September 1, 2026 18:04
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Coverage report — base devel

Overall (line): 83.30% → 83.30% (+0.00)
Regression threshold: 0.50% (line).

Regressions

(none over threshold)

Modules changed

Module Line Δ Function Δ Branch Δ
Os/Generic 90.04 -0.10 89.13 +0.00 74.33 -0.57
Svc/FileWorker 89.47 -0.07 100.00 +0.00 83.22 +0.20
Utils 44.14 +0.18 43.27 +0.00 47.14 +0.61
Os/Posix 64.43 +0.27 85.26 +0.00 45.92 +0.00
Fw/DataStructures 98.04 +0.35 97.14 +0.19 82.85 +0.55
Svc/CmdDispatcher 97.37 +0.37 91.67 +0.00 91.30 -0.19

New modules

Module Line Function Branch
Fw/Prm 0.00 0.00 0.00

Modules without UTs

CFDP/Checksum/GTest, Drv/LinuxGpioDriver, Drv/LinuxI2cDriver, Drv/LinuxSpiDriver, Drv/Ports/DataTypes, Drv/PosixUartDriver, FppTestProject/FppTest/topology/async, FppTestProject/FppTest/topology/components/Comp, FppTestProject/FppTest/topology/components/Framework, FppTestProject/FppTest/topology/components/Receiver, FppTestProject/FppTest/topology/components/Sender, FppTestProject/FppTest/topology/guarded, FppTestProject/FppTest/topology/sync, FppTestProject/FppTest/topology/top_ports, FppTestProject/FppTest/topology/types, Fw/Com, Fw/Comp, Fw/FilePacket/GTest, Fw/Fpy, Fw/Obj, Fw/Port, Fw/Sm, Fw/Test, Fw/Types/GTest, Os/Models, Svc/Ccsds/Types, Svc/FatalHandler, Svc/Subtopologies/CdhCore, Svc/Subtopologies/ComCcsds, Svc/Subtopologies/ComCcsdsSdls, Svc/Subtopologies/ComFprime, Svc/Subtopologies/ComLoggerTee, Svc/Subtopologies/DataProducts, Svc/Subtopologies/DpCompression, Svc/Subtopologies/FileHandling, Svc/Subtopologies/FileHandlingCfdp, Svc/Subtopologies/FileHandlingCfdp/FileHandlingCfdpConfig, TestDeploymentsProject/Ref/DpDemo, TestDeploymentsProject/Ref/PingReceiver, TestDeploymentsProject/Ref/RecvBuffApp, TestDeploymentsProject/Ref/SendBuffApp, TestDeploymentsProject/Ref/Top, TestDeploymentsProject/Ref/TypeDemo, cmake/test/data/TestConfigDeployment, cmake/test/data/TestDeployment/TestBuildAutocoder, cmake/test/data/TestDeployment/TestHeaderAutocoder, cmake/test/data/TestDeployment/TestLinkDepends, cmake/test/data/TestDeployment/TestRelative, cmake/test/data/test-fprime-library/TestLibrary/TestComponent, cmake/test/data/test-fprime-library2/TestLibrary2/TestComponent

@sylvesterkaczmarek sylvesterkaczmarek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The C++ alias preserves Drv::LinuxUartDriver, but the old FPP component definition is gone and the compatibility module no longer supplies an autocoder input. Existing topologies that instantiate Drv.LinuxUartDriver will therefore fail during FPP analysis/codegen even though the docs say it remains available. Could we preserve the FPP-facing compatibility too, or call this out as a breaking migration?

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@thomas-bc thomas-bc changed the title Add PosixUartDriver and deprecate LinuxUartDriver Rename LinuxUartDriver to PosixUartDriver and update restrictions Sep 2, 2026
@thomas-bc

Copy link
Copy Markdown
Collaborator Author

Good catch - I've made it remove the old LinuxUartDriver altogether, which is the original request of the issue

@thomas-bc thomas-bc added the Breaking Changes / Needs Release Notes Need to add instructions in the release notes for updates. label Sep 2, 2026

@LeStarch LeStarch left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit.

Comment thread Drv/PosixUartDriver/docs/sdd.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking Changes / Needs Release Notes Need to add instructions in the release notes for updates.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename LinuxUartDriver to PosixUartDriver and make available to POSIX platforms

3 participants