Skip to content

Fix task annotation parsing#159

Merged
mwang87 merged 4 commits into
dash-dashboardfrom
fix-task-annotation-parsing
Jul 28, 2021
Merged

Fix task annotation parsing#159
mwang87 merged 4 commits into
dash-dashboardfrom
fix-task-annotation-parsing

Conversation

@benpullman

Copy link
Copy Markdown
Collaborator
  1. Fix regex for splitting task identifiers to properly split annotation from scan
  2. Prioritize resolution on MassIVE for all USIs with annotations

Fixes #158

@benpullman
benpullman requested a review from mwang87 July 27, 2021 15:26
@benpullman
benpullman changed the base branch from master to dash-dashboard July 28, 2021 02:11
@mwang87
mwang87 merged commit 8718183 into dash-dashboard Jul 28, 2021

@bittremieux bittremieux left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has already been merged, but I still have some concerns. Can we discuss this a bit more?

Comment thread parsing.py
Comment thread parsing.py
@bittremieux
bittremieux deleted the fix-task-annotation-parsing branch July 29, 2021 15:33
bittremieux added a commit that referenced this pull request Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support ProForma Natively in Resolver

3 participants