Import dives: phase 1#34303
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (34)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (30)
📝 WalkthroughWalkthroughThe GuitarPro importer now parses whammy-bar curves into beat data, converts bend and dive pitch curves into shared segment structures, collects dive information, and builds typed bend elements in the score. The bend importer API and internal data contexts were reorganized, with new converter and collector components added to the build. GuitarPro 3–7 import paths use the new score-finalization method. New GP, GPX, and MuseScore fixtures and regression tests cover dive, harmonic, chord, coordinated, and prebend cases. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsLinked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/importexport/guitarpro/internal/gtp/gp67dombuilder.cpp`:
- Around line 1216-1237: Preserve the whammy curve’s origin offset by extending
the property parsing in readWhammy() to recognize WhammyBarOriginOffset and
assign its numeric value to whammyData.originOffset, alongside the existing
origin, destination, and middle value/offset properties.
In `@src/importexport/guitarpro/internal/guitarbendimport/bendbuilder.cpp`:
- Around line 214-231: The grace-note pitch calculation in the bend-building
flow must use the bend-chain start pitch for normal bends, matching the absolute
endpoint semantics of quarterTones. Update the graceNote setup near GuitarBend
creation to retain the currentNote-based additive calculation for DIVE, but
derive non-DIVE pitches from the chain-start note before calling
setTpcFromPitch().
In
`@src/importexport/guitarpro/tests/guitarbendimporter_data/dive_harmonic-gp.mscx`:
- Around line 145-151: Remove the duplicate WhammyBar terminator from the
fixture, leaving only the single valid prev location with fractions -1/1 for the
WhammyBar spanner. Preserve the existing WhammyBar start and its remaining
terminator unchanged.
In `@src/importexport/guitarpro/tests/guitarpro_tests.cpp`:
- Around line 606-612: Re-enable the Guitar Pro importer regression tests by
removing the DISABLED_ prefix from gpTremoloBar, gpxTremoloBar, and
gpLineElements. Fix or update the tremolo-bar/line-element importer behavior and
references so these tests pass while preserving their regression coverage.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 61db6477-70a0-4d18-9075-34a5106ebd97
📒 Files selected for processing (36)
src/importexport/guitarpro/CMakeLists.txtsrc/importexport/guitarpro/internal/gtp/gp67dombuilder.cppsrc/importexport/guitarpro/internal/gtp/gp67dombuilder.hsrc/importexport/guitarpro/internal/gtp/gpbeat.hsrc/importexport/guitarpro/internal/gtp/gpconverter.cppsrc/importexport/guitarpro/internal/guitarbendimport/bendbuilder.cppsrc/importexport/guitarpro/internal/guitarbendimport/bendbuilder.hsrc/importexport/guitarpro/internal/guitarbendimport/benddatacollector.cppsrc/importexport/guitarpro/internal/guitarbendimport/benddatacollector.hsrc/importexport/guitarpro/internal/guitarbendimport/benddatacontext.hsrc/importexport/guitarpro/internal/guitarbendimport/bendinfoconverter.cppsrc/importexport/guitarpro/internal/guitarbendimport/divedatacollector.cppsrc/importexport/guitarpro/internal/guitarbendimport/divedatacollector.hsrc/importexport/guitarpro/internal/guitarbendimport/diveinfoconverter.cppsrc/importexport/guitarpro/internal/guitarbendimport/diveinfoconverter.hsrc/importexport/guitarpro/internal/guitarbendimport/guitarbendimporter.cppsrc/importexport/guitarpro/internal/guitarbendimport/guitarbendimporter.hsrc/importexport/guitarpro/internal/guitarbendimport/guitarbendimporttypes.hsrc/importexport/guitarpro/internal/guitarbendimport/splitchord/benddatacollectorsplitchord.cppsrc/importexport/guitarpro/internal/importgtp-gp4.cppsrc/importexport/guitarpro/internal/importgtp-gp5.cppsrc/importexport/guitarpro/internal/importgtp.cppsrc/importexport/guitarpro/tests/guitarbendimporter_data/dive_chord-gp.mscxsrc/importexport/guitarpro/tests/guitarbendimporter_data/dive_chord.gpsrc/importexport/guitarpro/tests/guitarbendimporter_data/dive_down_up-gp.mscxsrc/importexport/guitarpro/tests/guitarbendimporter_data/dive_down_up.gpsrc/importexport/guitarpro/tests/guitarbendimporter_data/dive_harmonic-gp.mscxsrc/importexport/guitarpro/tests/guitarbendimporter_data/dive_harmonic.gpsrc/importexport/guitarpro/tests/guitarbendimporter_data/dive_with_prebend-gp.mscxsrc/importexport/guitarpro/tests/guitarbendimporter_data/dive_with_prebend.gpsrc/importexport/guitarpro/tests/guitarbendimporter_data/simple_dive-gp.mscxsrc/importexport/guitarpro/tests/guitarbendimporter_data/simple_dive-gpx.mscxsrc/importexport/guitarpro/tests/guitarbendimporter_data/simple_dive.gpsrc/importexport/guitarpro/tests/guitarbendimporter_data/simple_dive.gpxsrc/importexport/guitarpro/tests/guitarbendimporter_tests.cppsrc/importexport/guitarpro/tests/guitarpro_tests.cpp
💤 Files with no reviewable changes (1)
- src/importexport/guitarpro/internal/guitarbendimport/benddatacontext.h
alexpavlov96
force-pushed
the
import_dives
branch
from
July 22, 2026 08:59
ca7a17d to
9f9acdb
Compare
alexpavlov96
force-pushed
the
import_dives
branch
from
July 22, 2026 09:03
9f9acdb to
a6b4342
Compare
mikekirin
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.