[chat] Enforce top-level type imports by Janpot · Pull Request #23037 · mui/mui-x

Janpot · 2026-07-02T10:09:20Z

Adds the chat packages to the top-level type-imports rule (consistent-type-imports with separate-type-imports + import/consistent-type-specifier-style: prefer-top-level), following the same enforcement already in place for charts, data-grid, date-pickers (#22679), scheduler (#22931), and tree-view (#23034).

Commits:

The ESLint config change, plus one manual conversion of an import() type annotation in chat-stream.ts (the rule forbids these but cannot autofix them).
The mechanical eslint --fix + prettier result.

Add the chat packages to the consistent-type-imports / import-consistent-type-specifier-style block (top-level `import type {}`), following the existing enforcement for charts, data-grid, date-pickers, scheduler, and tree-view. Also manually converts one `import()` type annotation in chat-stream.ts to a top-level `import type`, which the rule forbids but cannot autofix.

Mechanical eslint --fix + prettier result for the rule enabled in the previous commit.

code-infra-dashboard · 2026-07-02T10:14:13Z

Deploy preview

https://deploy-preview-23037--material-ui-x.netlify.app/

Bundle size

Bundle	Parsed size	Gzip size
@mui/x-data-grid	0B^(0.00%)	0B^(0.00%)
@mui/x-data-grid-pro	0B^(0.00%)	0B^(0.00%)
@mui/x-data-grid-premium	0B^(0.00%)	0B^(0.00%)
@mui/x-charts	0B^(0.00%)	0B^(0.00%)
@mui/x-charts-pro	0B^(0.00%)	0B^(0.00%)
@mui/x-charts-premium	0B^(0.00%)	0B^(0.00%)
@mui/x-date-pickers	0B^(0.00%)	0B^(0.00%)
@mui/x-date-pickers-pro	0B^(0.00%)	0B^(0.00%)
@mui/x-tree-view	0B^(0.00%)	0B^(0.00%)
@mui/x-tree-view-pro	0B^(0.00%)	0B^(0.00%)
@mui/x-scheduler	0B^(0.00%)	0B^(0.00%)
@mui/x-scheduler-premium	0B^(0.00%)	0B^(0.00%)
@mui/x-chat	0B^(0.00%)	0B^(0.00%)
@mui/x-license	0B^(0.00%)	0B^(0.00%)

Details of bundle changes

Check out the code infra dashboard for more information about this PR.

Janpot · 2026-07-02T11:02:42Z

 export interface ChatStartMessageChunk {
  type: 'start';
  messageId: string;
-  author?: import('./chat-entities').ChatUser;


@hasdfa was this intentionally a dynamic import?

Ah, no, it feels like just it should not be dynamic import and I do not remember that there was some special case, so it's okay to replace it with normal import. Thanks!

Janpot · 2026-07-02T11:15:29Z

Some of the file names are kebab case, and some seem to be pascal/camelcase. Is there a rationale to having a few files kebab case, or is this unintential? The repo seems to heavily favor the latter

┌───────────────────────────────┬─────────────┬──────────────┬───────┐ │ Package │ kebab │ Pascal/camel │ total │ ├───────────────────────────────┼─────────────┼──────────────┼───────┤ │ x-telemetry │ 12 (100.0%) │ 0 (0.0%) │ 12 │ ├───────────────────────────────┼─────────────┼──────────────┼───────┤ │ x-charts-vendor │ 2 (100.0%) │ 0 (0.0%) │ 2 │ ├───────────────────────────────┼─────────────┼──────────────┼───────┤ │ x-codemod │ 195 (95.1%) │ 10 (4.9%) │ 205 │ ├───────────────────────────────┼─────────────┼──────────────┼───────┤ │ x-data-grid-generator │ 6 (18.2%) │ 27 (81.8%) │ 33 │ ├───────────────────────────────┼─────────────┼──────────────┼───────┤ │ x-scheduler-internals-premium │ 5 (6.2%) │ 76 (93.8%) │ 81 │ ├───────────────────────────────┼─────────────┼──────────────┼───────┤ │ x-scheduler-internals │ 9 (5.9%) │ 143 (94.1%) │ 152 │ ├───────────────────────────────┼─────────────┼──────────────┼───────┤ │ x-chat-headless │ 9 (5.6%) │ 152 (94.4%) │ 161 │ ├───────────────────────────────┼─────────────┼──────────────┼───────┤ │ x-scheduler │ 6 (3.9%) │ 148 (96.1%) │ 154 │ ├───────────────────────────────┼─────────────┼──────────────┼───────┤ │ x-date-pickers-pro │ 4 (2.9%) │ 136 (97.1%) │ 140 │ ├───────────────────────────────┼─────────────┼──────────────┼───────┤ │ x-date-pickers │ 5 (1.5%) │ 337 (98.5%) │ 342 │ ├───────────────────────────────┼─────────────┼──────────────┼───────┤ │ x-charts-pro │ 3 (1.5%) │ 198 (98.5%) │ 201 │ ├───────────────────────────────┼─────────────┼──────────────┼───────┤ │ x-charts │ 4 (0.6%) │ 624 (99.4%) │ 628 │ ├───────────────────────────────┼─────────────┼──────────────┼───────┤ │ x-data-grid │ 1 (0.2%) │ 446 (99.8%) │ 447 │ ├───────────────────────────────┼─────────────┼──────────────┼───────┤ │ x-virtualizer │ 0 (0.0%) │ 2 (100.0%) │ 2 │ ├───────────────────────────────┼─────────────┼──────────────┼───────┤ │ x-tree-view-pro │ 0 (0.0%) │ 18 (100.0%) │ 18 │ ├───────────────────────────────┼─────────────┼──────────────┼───────┤ │ x-tree-view │ 0 (0.0%) │ 74 (100.0%) │ 74 │ ├───────────────────────────────┼─────────────┼──────────────┼───────┤ │ x-scheduler-premium │ 0 (0.0%) │ 43 (100.0%) │ 43 │ ├───────────────────────────────┼─────────────┼──────────────┼───────┤ │ x-license │ 0 (0.0%) │ 16 (100.0%) │ 16 │ ├───────────────────────────────┼─────────────┼──────────────┼───────┤ │ x-internals │ 0 (0.0%) │ 44 (100.0%) │ 44 │ ├───────────────────────────────┼─────────────┼──────────────┼───────┤ │ x-internal-gestures │ 0 (0.0%) │ 104 (100.0%) │ 104 │ ├───────────────────────────────┼─────────────┼──────────────┼───────┤ │ x-data-grid-pro │ 0 (0.0%) │ 124 (100.0%) │ 124 │ ├───────────────────────────────┼─────────────┼──────────────┼───────┤ │ x-data-grid-premium │ 0 (0.0%) │ 149 (100.0%) │ 149 │ ├───────────────────────────────┼─────────────┼──────────────┼───────┤ │ x-chat │ 0 (0.0%) │ 104 (100.0%) │ 104 │ ├───────────────────────────────┼─────────────┼──────────────┼───────┤ │ x-charts-premium │ 0 (0.0%) │ 153 (100.0%) │ 153 │ └───────────────────────────────┴─────────────┴──────────────┴───────┘

Worth it to encode in lint rules?

For reference, mui/material-ui is also almost exclusively the latter

┌──────────────────────────┬─────────────┬─────────────────┬────────┐ │ Package │ kebab │ Pascal/camel │ total │ ├──────────────────────────┼─────────────┼─────────────────┼────────┤ │ mui-codemod │ 444 (89.0%) │ 55 (11.0%) │ 499 │ ├──────────────────────────┼─────────────┼─────────────────┼────────┤ │ mui-lab │ 1 (1.1%) │ 86 (98.9%) │ 87 │ ├──────────────────────────┼─────────────┼─────────────────┼────────┤ │ mui-material │ 1 (0.1%) │ 882 (99.9%) │ 883 │ ├──────────────────────────┼─────────────┼─────────────────┼────────┤ │ mui-utils │ 0 (0.0%) │ 94 (100.0%) │ 94 │ ├──────────────────────────┼─────────────┼─────────────────┼────────┤ │ mui-system │ 0 (0.0%) │ 98 (100.0%) │ 98 │ ├──────────────────────────┼─────────────┼─────────────────┼────────┤ │ mui-private-theming │ 0 (0.0%) │ 5 (100.0%) │ 5 │ ├──────────────────────────┼─────────────┼─────────────────┼────────┤ │ mui-styled-engine │ 0 (0.0%) │ 5 (100.0%) │ 5 │ ├──────────────────────────┼─────────────┼─────────────────┼────────┤ │ mui-styled-engine-sc │ 0 (0.0%) │ 4 (100.0%) │ 4 │ ├──────────────────────────┼─────────────┼─────────────────┼────────┤ │ mui-styled-engine-noop │ 0 (0.0%) │ 4 (100.0%) │ 4 │ ├──────────────────────────┼─────────────┼─────────────────┼────────┤ │ mui-material-pigment-css │ 0 (0.0%) │ 5 (100.0%) │ 5 │ ├──────────────────────────┼─────────────┼─────────────────┼────────┤ │ mui-material-nextjs │ 0 (0.0%) │ 4 (100.0%) │ 4 │ ├──────────────────────────┼─────────────┼─────────────────┼────────┤ │ mui-types │ 0 (0.0%) │ 1 (100.0%) │ 1 │ ├──────────────────────────┼─────────────┼─────────────────┼────────┤ │ mui-icons-material │ 0 (0.0%) │ 10,749 (100.0%) │ 10,749 │ └──────────────────────────┴─────────────┴─────────────────┴────────┘

Seems like newer packages more lean to kebab then camel)
Btw, it's not intentional to mix them so probably we should decide, at least per package which style do we want to go thought, or do you feel we should enforce it for whole repo?

or do you feel we should enforce it for whole repo?

If we were to adopt a convention we should make it company wide. But I wouldn't call it top priority.

github-actions · 2026-07-15T07:40:08Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

…ports # Conflicts: # packages/x-chat/src/ChatBox/ChatBox.tsx # packages/x-chat/src/ChatConversationList/ChatConversationList.tsx # packages/x-chat/src/ChatIndicators/ChatStreamingIndicatorRow.tsx # packages/x-chat/src/ChatMessage/ChatMessage.tsx

github-actions · 2026-07-17T06:06:25Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

hasdfa

LGTM

Janpot · 2026-08-28T14:34:58Z

@claude review low

…ports # Conflicts: # packages/x-chat/src/ChatBox/ChatBox.types.ts # packages/x-chat/src/ChatCodeBlock/ChatCodeBlock.tsx # packages/x-chat/src/ChatComposer/ChatComposerAttachmentList.tsx # packages/x-chat/src/ChatMessage/ChatMessageInlineMeta.tsx # packages/x-chat/src/ChatMessage/ChatMessageMeta.tsx

Janpot added 2 commits July 2, 2026 12:09

[chat] Apply top-level type-import autofix

44cd587

Mechanical eslint --fix + prettier result for the rule enabled in the previous commit.

Janpot commented Jul 2, 2026

View reviewed changes

Janpot mentioned this pull request Jul 2, 2026

Align file name casing mui/mui-public#1593

Open

Janpot added scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. labels Jul 2, 2026

Janpot marked this pull request as ready for review July 3, 2026 07:53

Janpot mentioned this pull request Jul 3, 2026

Add MUI X chat & scheduler packages to dashboard mui/mui-public#1596

Merged

github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jul 15, 2026

github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jul 15, 2026

Janpot requested a review from hasdfa July 15, 2026 11:04

github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jul 17, 2026

hasdfa approved these changes Aug 3, 2026

View reviewed changes

This comment was marked as resolved.

Sign in to view

Janpot added 2 commits August 28, 2026 16:48

[chat] Re-apply top-level type-import autofix after merge

202c2fc

github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 28, 2026

Merge branch 'master' into feat/chat-type-imports

9064914

Janpot merged commit 2935249 into mui:master Sep 3, 2026
22 checks passed

Navigation Menu

Uh oh!

Uh oh!

[chat] Enforce top-level type imports - #23037

[chat] Enforce top-level type imports#23037
Janpot merged 6 commits into
mui:masterfrom
Janpot:feat/chat-type-imports

Janpot commented Jul 2, 2026

Uh oh!

code-infra-dashboard Bot commented Jul 2, 2026 •

edited

Loading

Uh oh!

Janpot Jul 2, 2026

Uh oh!

hasdfa Aug 3, 2026

Uh oh!

Janpot Jul 2, 2026

Uh oh!

hasdfa Aug 3, 2026

Uh oh!

Janpot Aug 18, 2026

Uh oh!

github-actions Bot commented Jul 15, 2026

Uh oh!

github-actions Bot commented Jul 17, 2026

Uh oh!

hasdfa left a comment

Uh oh!

Janpot commented Aug 28, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

Janpot commented Jul 2, 2026

Uh oh!

code-infra-dashboard Bot commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploy preview

Bundle size

Uh oh!

Janpot Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

hasdfa Aug 3, 2026

Choose a reason for hiding this comment

Uh oh!

Janpot Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

hasdfa Aug 3, 2026

Choose a reason for hiding this comment

Uh oh!

Janpot Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 15, 2026

Uh oh!

github-actions Bot commented Jul 17, 2026

Uh oh!

hasdfa left a comment

Choose a reason for hiding this comment

Uh oh!

Janpot commented Aug 28, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

code-infra-dashboard Bot commented Jul 2, 2026 •

edited

Loading