Skip to content

Builders don't expose a locktime param #23

Description

@bc1cindy

BtcTransaction supports locktime (default defaultTxLocktime), but BitcoinTransactionBuilder and ForkedTransactionBuilder never thread it through, both build paths construct BtcTransaction(inputs, outputs) without it, so every built tx is stuck at the default locktime with no way for a caller to set it.

fix: add an optional locktime param to both builders and pass it into the BtcTransaction(...) calls. Computing the value stays the caller's job.

ref: payjoin/rust-payjoin#1597 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions