Add support for SassDoc previews on hover, in suggestions, and signature helper - #156
Closed
wkillerud wants to merge 10 commits into
Closed
Add support for SassDoc previews on hover, in suggestions, and signature helper#156wkillerud wants to merge 10 commits into
wkillerud wants to merge 10 commits into
Conversation
VS Code has started disabling certain features unless the workspace is trusted. By default with the previous runner, VS Code would start in this un-trusting mode, which broke Vue behavior. This new version of the runner adds the proper flags automatically so the workspace is trusted. See https://code.visualstudio.com/api/working-with-extensions/testing-extension#migrating-from-vscode
Fixes a failing e2e test
To be used by other features
Strict mode has been removed. tl;dr is to use queue instead. https://blog.mergify.com/strict-mode-deprecation/
Author
|
Looks like Mergify removed strict mode in favor of queue. e9ff4a7 should have the updated config, but the check will keep failing until the change hits the main branch. |
wkillerud
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, and thanks for your work building this plugin!
I wanted to run a suggested solution for #56 by you (the one about previewing SassDoc). It may be a bit naive performance-wise, but it seems to be working alright on my own machine. Basically it runs a SassDoc parse-command on the source file for a symbol, runs through the result to match the correct docs with the symbol, and builds up the preview.
I considered using StorageService to keep the result from
sassdoc.parse, but at least in my case it's very helpful to always have up-to-date documentation (I maintain a design system built with Sass, among other things, and would love to preview docs I write).Hope we can work together to land this feature. Here's a preview:
Edit 26/06/22: I've refined this feature further, but it builds on some foundational changes in the parser and scanner. I've published my fork as a separate extension, naturally giving credit for its origin. If you're interested in coordinating the two repos, feel free to reach out :)