[bug-1846013] Allows users to fetch results from all frameworks - #9761
Open
gopar wants to merge 1 commit into
Open
[bug-1846013] Allows users to fetch results from all frameworks#9761gopar wants to merge 1 commit into
gopar wants to merge 1 commit into
Conversation
✅ Deploy Preview for treeherder ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
gopar
commented
Aug 8, 2026
| # Build common result dictionary (contains only data both test versions use) | ||
| is_complete = base_runs_count and new_runs_count | ||
| resolved_framework = ( | ||
| framework or base_sig.get("framework_id") or new_sig.get("framework_id") |
Author
There was a problem hiding this comment.
Who should win here when framework is empty? base or new?
gopar
commented
Aug 8, 2026
Comment on lines
+2091
to
2100
| query_set = PerformanceSignature.objects.filter(parent_signature_id=None).prefetch_related( | ||
| "performancealert" | ||
| ) | ||
| if framework_id is not None: | ||
| query_set = query_set.filter(framework_id=framework_id) | ||
| query_set = ( | ||
| PerformanceSignature.objects.prefetch_related("performancealert") | ||
| .filter(framework_id=framework_id, parent_signature_id=None) | ||
| .values("suite", "test") | ||
| query_set.values("suite", "test") | ||
| .annotate(repositories=GroupConcat("repository_id", distinct=True)) | ||
| .annotate(platforms=GroupConcat("platform_id", distinct=True)) | ||
| .annotate(total_alerts=Count("performancealert")) |
Author
There was a problem hiding this comment.
So i don't see any tests related to this endpoint. Is it in use? When I tried writing a test I got some sql errors and it was because GroupConcat is a MySql feature not in postgres. is this dead code that should be removed then?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: API - make framework parameter optional