test suite

[dherman]

Need to choose a testing framework and set up a test suite.

[dherman]

Maybe mocha:

http://dailyjs.com/2011/12/08/mocha/
https://github.com/visionmedia/mocha

[juandopazo]

I wrote some tests using Mocha (see juandopazo@213ada3), but the issue is that since Task catches errors in the generator function there is no clear way to get Mocha to show the correct assertion failures.

Would you be interested in using YUI Test? It uses a resume() function for asynchronous tests that creates a new context to catch errors. Here's an example test:

'task should retrieve a promise\'s value': function () {
    var test = this,
        expected = 'hello world';

    spawn(function () {
        var actual = yield Promise.resolve(expected);
        test.resume(function () {
            Assert.areSame(expected, actual);
        });
    });
    test.wait();
}

[juandopazo]

Tests using YUI: juandopazo@bc26447.

Another option could be Jasmine. Jasmine tests look very similar to Mocha, but they also provide their own context for assertions through a runs function. It ends up being a lot more code though. See:

it('task should retrieve a promise\'s value': function () {
  var done = false;
  var someString = 'hello world';
  var value;

  runs(function () {
    spawn(function () {
      value = yield Promise.resolve(someString);
      done = true;
    });
  });

  waitsFor(function () {
    return done == true;
  });

  runs(function () {
    expect(value).to.eql(someString);
  });
});

[mbulman]

Fwiw, using doh (dojo's test harness) deferreds, the above test would look something like:

function testReturnValue() {
    var expected = "hello world",
        deferred = new doh.Deferred();

    spawn(deferred.getTestCallback(function() {
        var actual = yield Promise.resolve(expected);
        doh.assertEqual(expected, actual);
    }));

    return deferred;
}

Disclaimer: I just happened to be following this thread, and haven't tested the above code at all.

[juandopazo]

The problem with that version is that spawn expects a generator and getTestCallback returns a callback.

[mbulman]

Oh right. Then without the convenience of getTestCallback, it would look something like:

function testReturnValue() {
    var expected = "hello world",
        deferred = new doh.Deferred();

    spawn(function() {
        try {
            var actual = yield Promise.resolve(expected);
            doh.assertEqual(expected, actual);
            deferred.callback(true);
        } catch (e) {
            deferred.errback(e);
        }
    }));

    return deferred;
}