This repository was archived by the owner on Aug 28, 2018. It is now read-only.
Update striptags to the latest version 馃殌 - #328
Closed
greenkeeper[bot] wants to merge 1 commit into
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #328 +/- ##
==========================================
- Coverage 96.18% 96.15% -0.04%
==========================================
Files 12 12
Lines 367 364 -3
Branches 38 38
==========================================
- Hits 353 350 -3
Misses 10 10
Partials 4 4
Continue to review full report at Codecov.
|
Contributor
|
Versions of striptags >= 3.0.0 use ES6 code in the implementation, which causes the build process to fail because uglifyjs-webpack-plugin does not yet support minification of ES6 code. We will only be able to upgrade striptags to >= 3.0.0 once uglifyjs-webpack-plugin pushes a new version with this change and webpack-stream ultimately uses that version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 3.1.1 of striptags was just published.
The version 3.1.1 is not covered by your current version range.
If you don鈥檛 accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
It might be worth looking into these changes and trying to get this project onto the latest version of striptags.
If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don鈥檛 have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.
Commits
The new version differs by 15 commits.
127f2fbv3.1.1f80b3b8add typings94ceaf6v3.1.09ed9eb0Add IE11 support using minimal polyfill5eb9357Fix typo in README.md7179485Add notice about uglifyjs issues7427951v3.0.1517fd77Fix AMD bindings and fix AMD test.cd53825v3.0.09d9a804Update README.mdeb4d1f0Add test for streaming mode w/ allowable_tags.adf53b6Update mocha version and rewrite tests.86e95d2Remove HTML test coverage command and JSHint config.969cebdMove module back into src/ directory.dd1ed03Rewrite core module.See the full diff
FAQ and help
There is a collection of frequently asked questions. If those don鈥檛 help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper bot 馃尨