Use simple logical operator in middleware - #226
Merged
Conversation
Contributor
|
@sevdog can you rebase or recreate this change on the latest |
sevdog
force-pushed
the
improve-conditions
branch
from
July 8, 2024 08:21
f395c85 to
f11be06
Compare
Contributor
Author
|
Branch rebased. |
stevejalim
approved these changes
Jul 8, 2024
stevejalim
left a comment
stevejalim
left a comment
Contributor
There was a problem hiding this comment.
LGTM - thanks for the contribution @sevdog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The usage of
allis an overengineering of what can be handled with a simple sequence ofand.Also since
allis a function which requires an iterable as the only argument it is much slower than a simple logical operator.