Reawaken development - #204
Merged
Merged
Conversation
stevejalim
force-pushed
the
support-latest-djangos-and-pythons
branch
2 times, most recently
from
January 24, 2024 15:18
874e50b to
6c6ab4d
Compare
* Update tox matrix * Update Circle CI config * Update setup.py with newer Python versions
stevejalim
force-pushed
the
support-latest-djangos-and-pythons
branch
from
January 24, 2024 15:24
6c6ab4d to
3eadb4c
Compare
stevejalim
force-pushed
the
support-latest-djangos-and-pythons
branch
from
January 24, 2024 16:28
3eadb4c to
111c78f
Compare
stevejalim
force-pushed
the
support-latest-djangos-and-pythons
branch
from
January 24, 2024 16:42
235af88 to
ef195a1
Compare
Contributor
Author
|
@tim-schilling I'd welcome your review on this, too, if you don't mind |
stevejalim
force-pushed
the
support-latest-djangos-and-pythons
branch
from
January 24, 2024 17:11
9c1e81d to
b00c829
Compare
tim-schilling
approved these changes
Jan 24, 2024
tim-schilling
left a comment
tim-schilling
left a comment
There was a problem hiding this comment.
It looks good to me. I didn't run anything, just gave the code a once over. The issue I spotted wouldn't harm anything even.
Co-authored-by: Tim Schilling <tim@aspiredu.com>
robhudson
reviewed
Jan 24, 2024
robhudson
reviewed
Jan 24, 2024
robhudson
reviewed
Jan 24, 2024
robhudson
reviewed
Jan 24, 2024
robhudson
approved these changes
Jan 24, 2024
robhudson
left a comment
robhudson
left a comment
Collaborator
There was a problem hiding this comment.
r+wc - just noticed some string clean-up that isn't necessary but a nice-to-have to avoid awkward concatenations, presumably from the automated formatting.
stevejalim
force-pushed
the
support-latest-djangos-and-pythons
branch
from
January 24, 2024 21:18
2a99dc9 to
a5bf0b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset aims to jump start development on the project.
six(resolves Remove package six #199)pep8andflake8forruffpre-commitOnce this is merged to
main, we can look at any outstanding PRs and merge those that are safe/OK to merge. We'll then look to do a3.8alphaor3.8rcrelease, before a formal3.8release.The longer goal remains to get the project into a state where it can hopefully be absorbed into Django Core - see #135