Skip to content

Use default revision instead of tip as fallback - #3003

Merged
marco-c merged 3 commits into
mozilla:masterfrom
La0:fix-2994
Oct 8, 2025
Merged

Use default revision instead of tip as fallback#3003
marco-c merged 3 commits into
mozilla:masterfrom
La0:fix-2994

Conversation

@La0

@La0 La0 commented Oct 8, 2025

Copy link
Copy Markdown
Collaborator

Closes #2994

@La0 La0 self-assigned this Oct 8, 2025
@marco-c

marco-c commented Oct 8, 2025

Copy link
Copy Markdown
Collaborator

There's also "tip" in bot/code_review_bot/revisions.py which we probably need to replace with "default"

@La0
La0 requested review from Archaeopteryx and marco-c October 8, 2025 15:51
@La0
La0 marked this pull request as ready for review October 8, 2025 15:51
@La0

La0 commented Oct 8, 2025

Copy link
Copy Markdown
Collaborator Author

I had to represent the default as a branch in the unit test. I'm not 100% sure that's how it works on HGMO

@marco-c
marco-c requested a review from cgsheeh October 8, 2025 15:59
Comment thread bot/tests/test_analysis.py

@cgsheeh cgsheeh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marco-c
marco-c merged commit c776604 into mozilla:master Oct 8, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fallback to "default" instead of "tip"

3 participants