Skip to content

Add FXIOS-16429 [PrivacyDashboard] Hook up UI with data, minor UI and string updates - #35502

Merged
adudenamedruby merged 6 commits into
mainfrom
rgb/16429-boisterous-joyous-kangaroo
Sep 2, 2026
Merged

Add FXIOS-16429 [PrivacyDashboard] Hook up UI with data, minor UI and string updates#35502
adudenamedruby merged 6 commits into
mainfrom
rgb/16429-boisterous-joyous-kangaroo

Conversation

@adudenamedruby

@adudenamedruby adudenamedruby commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

📜 Tickets

Jira ticket
Github issue

💡 Description

  • change from hardcoded strings to l10n strings
  • hook up and add state for the Privacy Dashboard

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@adudenamedruby
adudenamedruby requested review from a team as code owners September 2, 2026 15:51
@adudenamedruby
adudenamedruby force-pushed the rgb/16429-boisterous-joyous-kangaroo branch from cd069eb to df6ec80 Compare September 2, 2026 16:28
@mobiletest-ci-bot

mobiletest-ci-bot commented Sep 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Messages
📖 Project coverage: 44.34%

💪 Quality guardian

2 tests files modified. You're a champion of test coverage! 🚀

🥇 Perfect PR size

Smaller PRs are easier to review. Thanks for making life easy for reviewers! ✨

✅ Code coverage

  • All new files meet their coverage thresholds.
  • No modified files had significant enough changes for the coverage gate to run.

Client.app: Coverage: 46.04

File Coverage
TrackerBlockerSheetState.swift 100.0% ✅
TrackerBlockerSheetViewController.swift 91.87% ✅
TrackerBlockerSheetStateProvider.swift 100.0% ✅
TrackerCategoryRowView.swift 97.08% ✅
BrowserCoordinator.swift 62.51% ✅

Generated by 🚫 Danger Swift against c20001d

camilapedraza
camilapedraza requested changes Sep 2, 2026
View reviewed changes

@camilapedraza camilapedraza left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @adudenamedruby!
So, unfortunately, because of how plurals work we need to make some changes to avoid grammatical pitfalls in many target locales. Left an example of the problem and suggested rewording to avoid the issue altogether!

Comment thread firefox-ios/Shared/Strings.swift Outdated
Comment thread firefox-ios/Shared/Strings.swift Outdated
Comment thread firefox-ios/Shared/Strings.swift Outdated
Comment thread firefox-ios/Shared/Strings.swift Outdated
@adudenamedruby @camilapedraza
Apply l10n suggestions!
c20001d 
Co-authored-by: Camila Pedraza <36695574+camilapedraza@users.noreply.github.com>
@adudenamedruby

adudenamedruby commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

@camilapedraza done :D

camilapedraza
camilapedraza approved these changes Sep 2, 2026
View reviewed changes

@camilapedraza camilapedraza left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

dataports
dataports reviewed Sep 2, 2026
View reviewed changes
Comment thread firefox-ios/Client/Frontend/Home/Homepage/TrackerBlockerModule/TrackerBlockerSheetState.swift
/// Nothing populates the filled states yet: `empty` is the only one the app constructs, and it is what the sheet
/// is presented with until the blocked-tracker data is wired up separately. The populated states are exercised
/// from sample data in `TrackerBlockerSheetViewControllerTests`.
/// `TrackerBlockerSheetStateProvider` builds whichever of the three the persisted stats call for.

@dataports dataports Sep 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm just slow today but I spent awhile trying to understand this comment. This is referring to the persisted stats being empty, filled, or weekly?

@adudenamedruby adudenamedruby Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. The comment above is tied to this change.

dataports
dataports approved these changes Sep 2, 2026
View reviewed changes

@dataports dataports left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, maybe one comment could be clearer? But not sure if that's not just me being sleepy lol

@adudenamedruby
adudenamedruby merged commit 8d7570b into main Sep 2, 2026
10 checks passed
@adudenamedruby
adudenamedruby deleted the rgb/16429-boisterous-joyous-kangaroo branch September 2, 2026 19:33
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

🚀 PR merged to main, targeting version: 156.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataports dataports dataports approved these changes
@camilapedraza camilapedraza camilapedraza approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adudenamedruby @mobiletest-ci-bot @dataports @camilapedraza