Document FXIOS-16744 [Build Instructions] Note the Xcode Swift macro approval prompt - #35500
Open
BrettThePark wants to merge 1 commit into
Open
Conversation
…approval prompt Add builds notes to the Readme file so contributers know that the macro needs to be trusted and is intentional
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Xcode requires an explicit approval before it will build the
ModifiedCopySwift macro, so the first build after a fresh clone stops on aTrust & Enabledialog. Nothing in the README mentions it, and dismissing it fails the build with a macro validation error that reads like a broken checkout rather than a pending approval.Adds one line to the build steps so the prompt is expected. It also notes the prompt can return later, since the approval is tied to the resolved package version.
No change to
focus-ios/README.md— Focus does not depend on the macro.Request for someone with wiki access: the same note would help on Automated Project Setup with FXIOS, where the page hands off to opening Xcode.
fxiospasses-skipMacroValidation, so nothing prompts during automated setup itself — the dialog only appears later on the first Cmd+R. I don't have wiki access.📝 Checklist