perf(json): cache stringify indentation - #4145
Open
mizchi wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves Json::stringify pretty-print performance by caching indentation strings per nesting depth, avoiding repeated construction of the same "\n" + spaces prefix during iterative stringification.
Changes:
- Replace per-write indentation string construction with a depth-indexed
indent_cacheand awrite_indenthelper. - Add a new benchmark test for deep/wide JSON stringification with
indent=2to validate the optimization’s impact.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| json/json.mbt | Caches pretty-print indentation strings by depth and reuses them throughout Json::stringify when indent > 0. |
| json/stringify_indent_bench_test.mbt | Adds a benchmark covering deep nesting with many innermost elements to measure indentation caching wins. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache pretty-print indentation strings by depth instead of rebuilding the same newline-and-spaces string for every array element or object member. Compact output keeps its existing branch and does not populate the cache.
Native benchmark (six nested arrays, 10,000 innermost values,
indent=2):Validation:
moon test json --target all,moon check --target all, andmoon info.