Skip to content

fix(viewer): respect base paths for asset surfaces#177

Merged
benvinegar merged 1 commit into
mainfrom
fix/base-path-asset-urls
Jun 28, 2026
Merged

fix(viewer): respect base paths for asset surfaces#177
benvinegar merged 1 commit into
mainfrom
fix/base-path-asset-urls

Conversation

@benvinegar

Copy link
Copy Markdown
Member

Summary

  • include configured base paths in REST asset upload URLs
  • load native image and trace assets through the viewer host base path
  • add API and embedded-viewer regressions for prefixed asset routes

Review

  • Ran three subagent code reviews (correctness, tests/coverage, maintainability). Correctness and tests reported no findings. Maintainability findings were addressed by encoding server asset ids and extracting shared embed bundle serving into e2e fixtures.

Tests

  • npm run format:check
  • npm run lint
  • npm run typecheck
  • npm test
  • npx playwright test e2e/uploads.spec.ts --project=chromium

This PR description was generated by Pi using GPT-5.1 Codex

@benvinegar benvinegar merged commit d26f7cc into main Jun 28, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant