fix(docker): switch to non-root user in all MCP server Dockerfiles - #4742
Open
somuai wants to merge 1 commit into
Open
fix(docker): switch to non-root user in all MCP server Dockerfiles#4742somuai wants to merge 1 commit into
somuai wants to merge 1 commit into
Conversation
Resolves modelcontextprotocol#4741. - Switch to 'app' user in Python images (fetch, git, time) - Switch to 'node' user in Node.js images (everything, filesystem, memory, sequentialthinking) - Prevents root container execution and root-owned host files on bind mounts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #4741.
Problem
fetch,git,time) created anappuser withuseradd -rUM -s /usr/sbin/nologin appand chowned/app/.venvtoapp:app, but never switched to it with aUSERinstruction.everything,filesystem,memory,sequentialthinking) usednode:22-alpinewithout switching to the pre-existingnodeuser.UID 0). In the case ofsrc/filesystem, bind mounts to host directories created files owned byroot, and Kubernetes admission controllers requiringrunAsNonRoot: truerejected the images.Solution
USER appbeforeENTRYPOINTin the Python images (src/fetch/Dockerfile,src/git/Dockerfile,src/time/Dockerfile).USER nodebeforeCMD/ENTRYPOINTin the Node.js images (src/everything/Dockerfile,src/filesystem/Dockerfile,src/memory/Dockerfile,src/sequentialthinking/Dockerfile).