Skip to content

Update Installation.rst#121

Merged
cosmic-cortex merged 1 commit intomodAL-python:devfrom
joecummings:patch-1
Feb 24, 2021
Merged

Update Installation.rst#121
cosmic-cortex merged 1 commit intomodAL-python:devfrom
joecummings:patch-1

Conversation

@joecummings
Copy link
Copy Markdown
Contributor

modAL/models/base.py imports _BaseHeterogeneousEnsemble from sklearn.ensemble._base. The first stable release in which the change from sklearn.ensemble.base to the protected sklearn.ensemble._base occurred appears to be v0.22. See https://scikit-learn.org/stable/whats_new/v0.22.html#clear-definition-of-the-public-api.

`modAL/models/base.py` imports `_BaseHeterogeneousEnsemble` from `sklearn.ensemble._base`. The first stable release in which the change from `sklearn.ensemble.base` to the protected `sklearn.ensemble._base` occurred appears to be `v0.22`. See https://scikit-learn.org/stable/whats_new/v0.22.html#clear-definition-of-the-public-api.
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #121 (1d5288d) into dev (99d4947) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #121   +/-   ##
=======================================
  Coverage   96.80%   96.80%           
=======================================
  Files          31       31           
  Lines        1786     1786           
=======================================
  Hits         1729     1729           
  Misses         57       57           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99d4947...1d5288d. Read the comment docs.

@cosmic-cortex cosmic-cortex merged commit 6445b3a into modAL-python:dev Feb 24, 2021
@cosmic-cortex
Copy link
Copy Markdown
Member

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants