Skip to content

chore: "Force" Netlify to use npm to build new site - #5319

Merged
JoshuaKGoldberg merged 31 commits into
mochajs:mainfrom
mark-wiemer:build-new-site
Mar 27, 2025
Merged

chore: "Force" Netlify to use npm to build new site#5319
JoshuaKGoldberg merged 31 commits into
mochajs:mainfrom
mark-wiemer:build-new-site

Conversation

@mark-wiemer

Copy link
Copy Markdown
Member

PR Checklist

Overview

"Force" Netlify to use npm instead of pnpm to get around our weird build issues.

Note this issue is only visible in Netlify so non-trusted contributors won't be able to see a lot of the context here.

Ref #5318 for links to a sample build and snippets of logs for context

@mark-wiemer mark-wiemer changed the title Build new site chore: "Force" Netlify to use npm to build new site Mar 26, 2025
Comment thread docs-next/src/content/docs/api/example.mdx Outdated

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome investigation and great one-liner result, nicely done! 👏 🔥

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author waiting on response from OP or other posters - more information needed label Mar 26, 2025
@mark-wiemer mark-wiemer added status: needs review a maintainer should (re-)review this pull request and removed status: waiting for author waiting on response from OP or other posters - more information needed labels Mar 26, 2025

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@JoshuaKGoldberg
JoshuaKGoldberg merged commit 3a46855 into mochajs:main Mar 27, 2025
@mark-wiemer
mark-wiemer deleted the build-new-site branch March 28, 2025 01:17
lennonnikolas pushed a commit to lennonnikolas/mocha that referenced this pull request Jan 24, 2026
* docs: add new website using Astro Starlight

* chore: add docs command to package.json

* Add supporters.js dependencies

* add root-level install to npm run docs

* remove question mark

* docs-next/netlify.toml

* console.log(process.env)

* Don't have /next base in Netlify

* More proper astro.config.mjs

* linting

* Smaller title

* Dark mode fixups

* Slightly darker sl-color-white

* Mentioned this being WIP

* Missing _

* Tweaked notice

* Tweaked notice colors

* Tweaked notice text

* fix /api and /example/tests.html links

* fix: responsive homepage title

* fix: sized responsive homepage title

* Added <Head> override for mocha-thumbnail.svg

* Added starting buttons

* fix: starting buttons config link

* fix: starting buttons 'ing'

* Footer mobile responsiveness, and root netlify.toml revert

* Simpler, more accurate test file

* Use npm explicitly

* Remove pnpm-lock.yaml

* Remove example.mdx

---------

Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
lennonnikolas pushed a commit to lennonnikolas/mocha that referenced this pull request Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: needs review a maintainer should (re-)review this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🛠 Repo: New site isn't deployed to mochajs.org/next

2 participants