WIP: Migrate Travis jobs to GitHub Actions#8514
Conversation
|
While you're digging around in CIs, could you add a step to all Azure runs that actually checks the commit message for I see two ways of doing it:
Not sure which is better, or if there is another better alternative |
|
Finally a skip. Now I have to work on a reliable conditional |
|
Okay I think Azure is good to go now |
| if: success() | ||
| name: 'Upload coverage to CodeCov' | ||
|
|
||
| # Minimal (runs with and without testing data) |
There was a problem hiding this comment.
Separate files would be better for restartability
There was a problem hiding this comment.
I'll separate them all then
There was a problem hiding this comment.
Yes the GitHub ones (Azure can and should stay a single file)
| name: 'Upload coverage to CodeCov' | ||
|
|
||
| # PIP + non-default stim channel + log level info | ||
| pip: |
| @@ -0,0 +1,38 @@ | |||
| name: 'maint' | |||
| - bash: | | ||
| make flake | ||
| displayName: make flake | ||
| condition: always() |
There was a problem hiding this comment.
| - bash: | | |
| make flake | |
| displayName: make flake | |
| condition: always() |
| - bash: | | ||
| make codespell-error | ||
| displayName: make codespell-error | ||
| condition: always() |
There was a problem hiding this comment.
| - bash: | | |
| make codespell-error | |
| displayName: make codespell-error | |
| condition: always() |
|
For future reference, I got the infos of the correct usage of |
|
This is ready for reviews but:
|
|
@GuillaumeFavelier our minimum is 1.15 and that part of the test is skipped for 1.16+, we should just skip it entirely. For now maybe just comment it out so that someday we come back to it? |
|
I'll merge and we can iterate more as necessary, thanks @GuillaumeFavelier ! |
|
can you update the badges on readme @GuillaumeFavelier ? thanks heaps ! |
|
Looks like you can make them for GitHub actions like https://github.com/mne-tools/mne-python/workflows/linux%20/%20conda/badge.svg?branch=master: |
|
Great work! Do we have any numbers on how long tests take on GitHub Actions vs. how long they took on Travis? AFAIK the longest job on Travis was around 50-55 minutes... |
|
Yes the |
This PR follows #8335 (comment) and migrates all remaining jobs on Travis to GitHub Actions.
ToDo:
compat / oldjobTRAVIS_OS_NAMEvariable[skip azp]mechanism (suggested in WIP: Migrate Travis jobs to GitHub Actions #8514 (comment))This is still work in progress.