Skip redrawing hscroll annotations when not needed#13972
Open
frankier wants to merge 2 commits into
Open
Conversation
Member
|
Sounds reasonable to me and I will test shortly, but in the meantime can you add |
Member
|
After removing the unnecessary load/save round-trip and reducing channel count to 32 by using (Side note, both are quite a bit slower than the |
0c4b654 to
9880770
Compare
Skip replotting of annotations on the horizontal scrollbar in the matplotlib browser backend, resulting in a significant speedup for traces with a large number of annotations by `Frankie Robertson`_.
9880770 to
609d3ac
Compare
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
If you have a file with a lot of annotations, all annotations on the horizontal scrollbar are redrawn unneccesarily, making horizontal scrolling very slow. This PR changes things so the annotations are only redrawn when needed.
This PR is written by hand, but the script to generate the example data given below is written by Claude Opus.
This can then be plotted like so:
If you try before and after this PR, you will notice horitzontal scrolling is significantly faster afterwards.