Potential fix for code scanning alert no. 14: Failure to use secure cookies - #906
Closed
SaboniAmine wants to merge 1 commit into
Closed
Potential fix for code scanning alert no. 14: Failure to use secure cookies#906SaboniAmine wants to merge 1 commit into
SaboniAmine wants to merge 1 commit into
Conversation
…ookies Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Contributor
|
Hello @SaboniAmine is this PR still needed ? |
Member
Author
|
No, we can close it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/mlco2/codecarbon/security/code-scanning/14
To address the issue, we should ensure that the cookie is always created with secure attributes:
secureattribute toTrueto ensure the cookie is only transmitted over HTTPS.samesiteattribute with a value of'Lax'to protect against CSRF attacks while allowing some cross-origin requests.httponlyattribute remains set toTrueto prevent JavaScript access to the cookie.These changes should be applied to the
response.set_cookiecall in the provided code.Suggested fixes powered by Copilot Autofix. Review carefully before merging.