Rewrite the window name tests to avoid forcing a pattern#294
Merged
stof merged 1 commit intominkphp:masterfrom Oct 3, 2018
Merged
Rewrite the window name tests to avoid forcing a pattern#294stof merged 1 commit intominkphp:masterfrom
stof merged 1 commit intominkphp:masterfrom
Conversation
Selenium defines the window name as a opaque string, so each browser is free to use anything they want. And this changed over time, causing the UUID regex to break even for browsers using a UUID in the past (Chrome adds more things around the UUID for instance).
Member
|
OK. |
Member
Author
|
this makes these tests pass when running them locally against chrome and firefox |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selenium defines the window name as a opaque string, so each browser is free to use anything they want. And this changed over time, causing the UUID regex to break even for browsers using a UUID in the past (Chrome adds more things around the UUID for instance).