Skip to content

Enable Pretty runner on Windows #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovro-bikic merged 1 commit into from
Jan 8, 2022
+0 −11
Merged

Enable Pretty runner on Windows #705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions lib/mina/runner.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ class Runner

def initialize(commands, backend)
fail 'You must specify execution mode' if execution_mode.nil?
fail 'Unsuported execution mode (pretty on windows)' if unsuported_execution_mode?

@backend = backend
@commands = commands
Expand All @@ -33,10 +32,6 @@ def script
Mina::Backend.const_get(class_name_for(backend)).new(commands).prepare
end

def unsuported_execution_mode?
execution_mode == :pretty && Gem::Platform.local.os == :windows
end

def class_name_for(symbol)
symbol.to_s.split('_').map(&:capitalize).join
end
Expand Down
6 changes: 0 additions & 6 deletions spec/lib/mina/runner_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,6 @@
expect { described_class.new(nil, nil) }.to raise_error('You must specify execution mode')
end

it 'raises an error when run on windows and pretty print' do
instance.set(:execution_mode, :pretty)
allow(Gem::Platform.local).to receive(:os).and_return(:windows)
expect { described_class.new(nil, nil) }.to raise_error('Unsuported execution mode (pretty on windows)')
end

it 'sets execution mode to printer if simulate is true' do
instance.set(:execution_mode, :pretty)
instance.set(:simulate, true)
Expand Down