Skip to content

node_modules in shared_paths #604

Description

@dddrey

Hey, guys.
It's not an issue, I'm just wondering if it's a good practice to put node_modules in shared_paths.
Because i did this thing and my deploy time decreased almost 3 times (from 6.5 mins -≥ to 2.5 mins) and nothing broke or failed.
Logic is that npm doesn't have to install all packages into node_modules directory every time deploying (it costs a lot by the way), only update some packages if necessary (like on local machine).

Steps i did:

cp /path_to_app/current/node_modules /path_to_app/shared
sudo chmod -R 777 /path_to_app/shared/node_modules (maybe not necessary)
add "node_modules" into :shared_paths
mina deploy:link_shared_paths
mina deploy

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions