Skip to content

fix: [3.0] avoid duplicate chown layers in runtime images - #53251

Open
zhikunyao wants to merge 1 commit into
milvus-io:3.0from
zhikunyao:backport/53174-runtime-image-layers-3.0
Open

fix: [3.0] avoid duplicate chown layers in runtime images#53251
zhikunyao wants to merge 1 commit into
milvus-io:3.0from
zhikunyao:backport/53174-runtime-image-layers-3.0

Conversation

@zhikunyao

Copy link
Copy Markdown
Collaborator

Backport of #53174 to the 3.0 branch.

What

  • create the milvus user and writable runtime directories before copying artifacts
  • use Docker COPY --chown=milvus:milvus to avoid the duplicate recursive-chown image layer
  • keep milvus:milvus as the default OSS runtime user while allowing downstream builds to set MILVUS_RUNTIME_USER
  • generate the FIPS config as the milvus user

Verification

  • git diff --check upstream/3.0..HEAD
  • the net patch matches fix: avoid duplicate chown layers in runtime images #53174 exactly; stable patch ID: 4e7833bebecc661047e1e0b9552f319e8c24654d
  • all six runtime Dockerfiles define the default runtime user and all 18 artifact copies use --chown=milvus:milvus
  • all four FIPS Dockerfiles switch to milvus:milvus before openssl fipsinstall

Image build and multi-architecture validation are left to CI.

Backport milvus-io#53174.

Signed-off-by: Zhikun Yao <zhikun.yao@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Sep 7, 2026
@sre-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign zhengbuqian after the PR has been reviewed.
You can assign the PR to them by writing /assign @zhengbuqian in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify Bot added the dco-passed DCO check passed. label Sep 7, 2026
@mergify

mergify Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

@zhikunyao Please associate the related pr of master to the body of your Pull Request. (eg. "pr: #")

@mergify mergify Bot added do-not-merge/missing-related-pr kind/bug Issues or changes related a bug labels Sep 7, 2026
@sre-ci-robot sre-ci-robot added the do-not-merge/need-merge-master-first any pr merge to release branch need to merge master first label Sep 7, 2026
@sre-ci-robot

Copy link
Copy Markdown
Contributor

[ci-v2-notice]
Notice: ci-v2 system is enabled for this PR (3.0 branch).

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check-macos // for Code Checker MacOS (GitHub Actions)
  • /ci-rerun-build-ut-cov // for ci-v2/build-ut-cov (build + unit tests)
  • /ci-rerun-e2e-amd // for ci-v2/e2e-amd (e2e tests)
  • /ci-rerun-e2e-amd-gray // for ci-v2/e2e-amd-gray (TC pool shadow; non-gating)
  • /ci-rerun-e2e-dist-wp // for ci-v2/e2e-dist-wp (Tencent distributed woodpecker-service boundary)
  • /ci-rerun-gosdk // for ci-v2/go-sdk (Go SDK E2E tests)
  • /ci-rerun-gosdk-std // for ci-v2/go-sdk-std (Go SDK E2E, standalone)
  • /ci-rerun-gosdk-dist-wp // for ci-v2/go-sdk-dist-wp (distributed + Woodpecker service)

If you have any questions or requests, please contact @zhikunyao.

@sre-ci-robot sre-ci-robot added the do-not-merge/need-milestone generate by v2-label-manager label Sep 7, 2026
@sre-ci-robot

Copy link
Copy Markdown
Contributor

[INFO] PR Label Summary by Default
[WARNING] No dependent PR reference found

  • Target branch '3.0' requires a PR merged to master first
  • Please add reference in format 'pr: #number'

[WARNING] Milestone not set

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

@sre-ci-robot

Copy link
Copy Markdown
Contributor

❌ CI Loop Results ac25e1b

Stage Result Duration Tests
✅ Build SUCCESS 16.6min -
❌ Code-Check FAILURE 8.7min -
❌ UT-Integration SKIPPED - -
❌ UT-GO SKIPPED - -
✅ UT-CPP-Cov SUCCESS 57.9min 8739 total, 8739 passed, 0 failed

Total: 80min | Pipeline | Artifacts

Failed Test Logs:

@mergify mergify Bot added the ci-passed label Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-passed dco-passed DCO check passed. do-not-merge/missing-related-pr do-not-merge/need-merge-master-first any pr merge to release branch need to merge master first do-not-merge/need-milestone generate by v2-label-manager kind/bug Issues or changes related a bug size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants