Skip to content

enhance: harden schema bump integrity checks - #53222

Open
MrPresent-Han wants to merge 1 commit into
milvus-io:masterfrom
MrPresent-Han:codex/bump-schema-integrity-hardening
Open

enhance: harden schema bump integrity checks#53222
MrPresent-Han wants to merge 1 commit into
milvus-io:masterfrom
MrPresent-Han:codex/bump-schema-integrity-hardening

Conversation

@MrPresent-Han

@MrPresent-Han MrPresent-Han commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

issue: #51649

What

  • validate schema-bump function-output ownership and StructArray physical integrity before reader setup
  • reject duplicate Function output-field ownership before constructing materializers
  • preserve StructArray projection and reject unsupported TEXT materialization inputs early
  • reconcile full-rewrite input rows and filtered/written row conservation before finalization
  • validate StorageV3 manifest column-group pointer/count invariants

@sre-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign zhuwenxing after the PR has been reviewed.
You can assign the PR to them by writing /assign @zhuwenxing in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Sep 7, 2026
@sre-ci-robot
sre-ci-robot requested review from sunby and tedxu September 7, 2026 02:30
@mergify mergify Bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Sep 7, 2026
@sre-ci-robot

Copy link
Copy Markdown
Contributor

[ci-v2-notice]
Notice: New ci-v2 system is enabled for this PR.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-code-check-macos // for Code Checker MacOS (GitHub Actions)
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-build-all // for ci-v2/build-all (multi-arch builds)
  • /ci-rerun-buildenv // for ci-v2/build-env (build milvus-env builder images; update .env after the new tag is ready)
  • /ci-rerun-ut-integration // for ci-v2/ut-integration, will rerun ci-v2/build
  • /ci-rerun-ut-go // for ci-v2/ut-go, will rerun ci-v2/build
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp, will rerun ci-v2/build
  • /ci-rerun-e2e-default // for ci-v2/e2e-default
  • /ci-rerun-e2e-amd // for ci-v2/e2e-amd (e2e pool dispatcher)
  • /ci-rerun-e2e-dist-wp // for ci-v2/e2e-dist-wp (Tencent distributed woodpecker-service boundary)
  • /ci-rerun-build-ut-cov // for ci-v2/build-ut-cov (build + unit tests in one pipeline)
  • /ci-rerun-build-ut-cov-tcus // force TC-US shadow
  • /ci-rerun-gosdk // for ci-v2/go-sdk (Go SDK E2E tests, ARM)
  • /ci-rerun-gosdk-std // for ci-v2/go-sdk-std (Go SDK E2E, standalone)
  • /ci-rerun-gosdk-dist-wp // for ci-v2/go-sdk-dist-wp (Go SDK E2E, distributed + Woodpecker service)

If you have any questions or requests, please contact @zhikunyao.

@MrPresent-Han

Copy link
Copy Markdown
Contributor Author

/ci-rerun-ut-go

@sre-ci-robot

Copy link
Copy Markdown
Contributor

❌ CI Loop Results 511c2bf

Stage Result Duration Tests
✅ Build SUCCESS 17.3min -
❌ Code-Check FAILURE 5.3min -
❌ UT-Integration SKIPPED - -
❌ UT-GO SKIPPED - -
✅ UT-CPP-Cov SUCCESS 65.9min 8817 total, 8817 passed, 0 failed

Total: 89min | Pipeline | Artifacts

Failed Test Logs:

@MrPresent-Han

Copy link
Copy Markdown
Contributor Author

/ci-rerun-e2e-default

@MrPresent-Han
MrPresent-Han force-pushed the codex/bump-schema-integrity-hardening branch from 511c2bf to 73061f4 Compare September 7, 2026 12:29
@sre-ci-robot

Copy link
Copy Markdown
Contributor

❌ CI Loop Results 73061f4

Stage Result Duration Tests
❌ Build FAILURE 15.9min -
❌ Code-Check SKIPPED - -
❌ UT-Integration SKIPPED - -
❌ UT-GO SKIPPED - -
❌ UT-CPP-Cov SKIPPED - -

Total: 19min | Pipeline | Artifacts

Failed Test Logs:

Signed-off-by: MrPresent-Han <chun.han@gmail.com>
@MrPresent-Han
MrPresent-Han force-pushed the codex/bump-schema-integrity-hardening branch from 73061f4 to 1324e0e Compare September 7, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants